Refined-github: Strike through link to closed issue

Created on 4 Apr 2017  路  4Comments  路  Source: sindresorhus/refined-github

Like Bugzilla, strike through the link to a closed issue or PR. Perhaps some slightly different formatting for merged PRs as well. cf https://github.com/isaacs/github/issues/451, https://github.com/isaacs/github/issues/313

enhancement
Source
picture durka
👍2

Most helpful comment

I would have liked that if it could have been done without requests.

Regarding the actual UI, I'd go with an icon of open/closed issue/PR. This way you'll also know what's this number is referring to.

picture hkdobrev on 7 May 2017
👍3

All 4 comments

Would be useful indeed, but we would have to use the GitHub API for this, which has limits on how many requests we can do, so it gets complicated fast. We would also need to have an options page for the user to save their token. We could fetch the whole page instead and have no limits, but that's wasteful.

sindresorhus picture sindresorhus on 5 May 2017
👍1

I would have liked that if it could have been done without requests.

Regarding the actual UI, I'd go with an icon of open/closed issue/PR. This way you'll also know what's this number is referring to.

hkdobrev picture hkdobrev on 7 May 2017
👍3

This seems to be the same as #202.

durka picture durka on 9 May 2017

@durka You are absolutely right! Closing in favour of #202.

hkdobrev picture hkdobrev on 9 May 2017
Was this page helpful?
0 / 5 - 0 ratings

Related issues

hkdobrev picture hkdobrev  路  3Comments
alexanderadam picture alexanderadam  路  3Comments
sindresorhus picture sindresorhus  路  3Comments
sompylasar picture sompylasar  路  3Comments
mischah picture mischah  路  3Comments