Refined-github: Repo homepage inserted into top of issues page?

[joshmanders]

Not exactly sure how to explain this, but I ran into it on a private repo that has zero code but I use the issues of that repo. I can't reproduce it on any other repo but this one.

I disable refined github and it goes away. Re-enable and it comes back.

[hkdobrev]

@joshmanders Does that happen on full page reload or only when you go back and forwards?

[hkdobrev]

@joshmanders could you try and set up a public test repo and see if you could reproduce?

[joshmanders]

@hkdobrev This happens on full page reload. I can't get it to happen on any other repo, I can make that repo public and test again, If it doesn't happen unless it's private, I can add you to it.

[joshmanders]

It's public and I get it still. https://github.com/joshmanders/ideas/issues

[jacobbearden]

I've identified this function as the cause. Gonna take a crack at fixing it.

[jacobbearden]

So when the function highlighted above creates uri, the resulting link appear as follows:
Empty repository, repository with files
Causing include-fragment to load the entire repository main page when the repository is empty.

What's the best way to check if a repository is empty?

[jacobbearden]

@sindresorhus @paulmolluzzo @hkdobrev

[paulmolluzzo]

What's the best way to check if a repository is empty?

Check that there are files in the file navigation? Or that the number of commits is >= 1? If you make a fake empty repo and visit in an incognito window there might be even more obvious stuff.

[joshmanders]

Any momentum?

[DrewML]

@joshmanders submitted a PR