Powertoys: [Color Picker] Color Picker randomly activates with hitting Shift+C

[CaptOveur]

ℹ Computer information

• Windows build number: 19041.388
• PowerToys version: 0.20.1
• PowerToy module: Color Picker

📝 Provide detailed reproduction steps (if any)

Hitting Shift+C during normal typing will randomly activate the color picker.

✔️ Expected result

Color Picker should only activate when hitting Shift+Win+C

[crutkas]

I can't repro this. Do you have any other apps like maybe AutoHotKeys installed?

[CaptOveur]

Nope. Nothing like that.

However I did reinstall it a little while ago so we'll see if that makes a difference. I'll post an update in 24 hours.

[holzfuss]

Same here.
v0.20.1
Settings: Win+Shift+C

Randomly Color Picker is activated by pressing Shift + C.

[CaptOveur]

It just happened when I typed "Called". So reinstalling 0.20.1 did not help.
I should also mention that this started happening after the feature was introduced in 0.20.0.
I'm going to change the key combo to Win+Shift+H and see what happens.

[arjunbalgovind]

I can repro this. A reliable repro is to press and hold win key, bring any window running as admin to the foreground (like task manager) and release the win key. Now go back to a non admin window and hit Shift+C, it will open color picker. Seems to be happening because Color picker is checking the modifier key states based on key up/down rather than GetAsyncKeyState.

[CaptOveur]

I can repro this. A reliable repro is to press and hold win key, bring any window running as admin to the foreground (like task manager) and release the win key. Now go back to a non admin window and hit Shift+C, it will open color picker. Seems to be happening because Color picker is checking the modifier key states based on key up/down rather than GetAsyncKeyState.

I just tried that a handful of time and the color picker never appeared.

[arjunbalgovind]

@CaptOveur are you running PowerToys as admin? The above repro would happen only if it is not running as administrator.

[lwestfall]

I was able to repro every time using @arjunbalgovind's method, when PowerToys is not running as admin. Otherwise it's hard to repro on-demand.

[CaptOveur]

@CaptOveur are you running PowerToys as admin? The above repro would happen only if it is not running as administrator.

I can repro with PowerToys not running as admin as well. And even if the key combo is set to Win+Shift+H it will open the color picker when Shift+H is pressed.

[arjunbalgovind]

It's possible to repro it with above steps with simpler shortcuts as well. If you set it to just Shift+C as well you can do the same steps to invoke it by just pressing C. @crutkas we should look into rewriting this hook to be similar to FZ/PT Run.

[crutkas]

@arjunbalgovind agreed on standardizing. If you point me to the right spot, I may be able to do it.

[Apreche]

I have the default of Win + Shift + C. I'll just be typing, and the color picker will suddenly appear even though I have definitely not pressed the Win key. Every time I look back and there's a capital C in the text I typed somewhere.

The thing is, I can't reproduce it with the method described here, or any other method. It just appears by accident several times a day, and I have not figured out how to reproduce. It is very annoying, though.

[enricogior]

Closing this in favor of https://github.com/microsoft/PowerToys/issues/6060 since we are going to move the handler to the runner.