Powertoys: MSIX: Possible heap corruption in ImageResizer

Created on 13 Mar 2020  路  6Comments  路  Source: microsoft/PowerToys

Steps to reproduce

  • get latest master and go to installer\MSIX from vsdev ps-shell
  • .\build_msix.ps1 -debug 1
  • .\sign_msix.ps1
  • .\install_msix.ps1
  • right-click some image in explorer

    Screenshots

image

Area-MSIX Issue-Bug Product-Image Resizer Resolution-Fix-Committed
Source
picture yuyoyuppe

All 6 comments

does this happen in an msi build?!?

crutkas picture crutkas on 13 Mar 2020

or just msix

crutkas picture crutkas on 13 Mar 2020

@crutkas just msix

yuyoyuppe picture yuyoyuppe on 13 Mar 2020

@yuyoyuppe thanks for the find! I had not used the Debug build with MSIX before so I never saw this error. Turns out I was using free instead of CoTaskMemFree for deallocating a string, and that caused this error to show up for any file on invoking the right-click menu.

arjunbalgovind picture arjunbalgovind on 23 Mar 2020
👍1

@yuyoyuppe The fix is in master, can you verify that the heap corruption error doesn't occur any more?

arjunbalgovind picture arjunbalgovind on 25 Mar 2020

fix confirmed.

yuyoyuppe picture yuyoyuppe on 25 Mar 2020
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

ivadham picture ivadham  路  3Comments
Satanarious picture Satanarious  路  3Comments
CombeeMike picture CombeeMike  路  3Comments
seritools picture seritools  路  3Comments
niels9001 picture niels9001  路  3Comments