Polaris-react: ResourceList placeholder prop

Created on 27 Mar 2019  路  6Comments  路  Source: Shopify/polaris-react

Feature request summary

Adding a placeholder prop to the ResourceList to allow users to set their own messages in the search area.

Rationale

image

Adding a prop like this would allow users to customize the placeholder text shown in the search area. Right now it defaults to the value in the resourceName prop.


馃専 Feature requests that are not yet planned will be closed. We then use the issue鈥檚 :+1: upvotes to track and set priorities. See the contribution guidelines for more information.

Most helpful comment

@danrosenthal @dleroux I think it makes sense to add it to the FilterControl I think because that is what is needed to get this UI to appear.

All 6 comments

馃憢 Thanks for opening your first issue. A contributor should give feedback soon. If you haven鈥檛 already, please check out the contributing guidelines. You can also join #polaris on the Shopify Partners Slack.

I think this should be added to ResourceList's context, making it accessible through a consumer. And FilterControl ought to get the value through context. Does anyone have an alternative solution?

cc: @dleroux

The prop would be on the ResourceList.FilterControl component as oppose to just the ResourceList

Do you see a need that this would be needed elsewhere? I see this more a concern specifically for the FilterControl. The bulk action would still show the ResourceName.

@danrosenthal @dleroux I think it makes sense to add it to the FilterControl I think because that is what is needed to get this UI to appear.

Yup, that makes sense to me 馃殺

Sorry I'm a little late to the party. I think it makes sense to have the prop on FilterControl as well

Was this page helpful?
0 / 5 - 0 ratings