Polaris-react: [RangeSlider] remove implementation of accessibility inputs

Created on 9 Jan 2019  路  3Comments  路  Source: Shopify/polaris-react

784 implements the DualThumb range slider with text inputs for accessibility purposes. These should be removed in favor of documentation that describes or directly illustrates the use of alternative inputs for accessibility. This could either be illustrated in a second example, or described in the Accessibility section added in @dpersing's accessibility documentation work.

In addition to removing any markup and handlers for these elements, we will also want to remove the prop specified here.

|accessibility inputs shown in red|
|-|
|screen_shot_2019-01-09_at_1_11_16_pm|

All 3 comments

documentation that describes or directly illustrates the use of alternative inputs for accessibility.

@danrosenthal I'd strongly favor:

  • Documentation that describes the accessibility differences between the single- and dual-thumb sliders out of the box (I can work on that today/this week as part of the style guide updates)
  • A best practice Playground/Storybook example showing the dual-thumb slider with text/number inputs.

@dpersing I'm good with that!

@dpersing FYI, Liz and I have a WIP PR.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

greghesp picture greghesp  路  3Comments

shahab65 picture shahab65  路  3Comments

janklimo picture janklimo  路  3Comments

HYPD picture HYPD  路  3Comments

nemoeric picture nemoeric  路  3Comments