Polaris-react: Document configuration of i18n on AppProvider for pulling in translations and remove english as default
Related to this comment: https://github.com/Shopify/polaris-react/pull/1358#issuecomment-488477477, we want to clearly document the approach for pulling in non-english translations to the AppProvider. We may consider making i18n a required prop, and removing the default English translations.
danrosenthal
All 3 comments
cc: @AndrewMusgrave
danrosenthal
on 7 May 2019
Going to tackle this on Friday || Monday and put together a MVP. If we're making i18n a required prop we'll want to bunch this into v4
AndrewMusgrave
on 16 May 2019
👍2
Going to remove myself as an assignee on this. Let me know if there is something you need me to do and I will slot it in. I鈥檓 reserving assignee status for "I鈥檓 actively working on this".
tmlayton
on 16 May 2019
👍2
Was this page helpful?
0 / 5 - 0 ratings
Related issues
alex-page
路
3Comments
vilav
路
3Comments
shahab65
路
3Comments
mbaumbach
路
3Comments
danrosenthal
路
3Comments
Most helpful comment
Going to remove myself as an assignee on this. Let me know if there is something you need me to do and I will slot it in. I鈥檓 reserving assignee status for "I鈥檓 actively working on this".