Polaris-react: ActionList item's onAction submits ancestor form

[andrewpye]

Issue summary

If an ActionList component is used inside a form element, selecting any action from the list triggers the form's onSubmit handler:

Source for the above GIF is here.

Expected behavior

Clicking an item should not trigger an ancestor form's onSubmit handler.

Actual behavior

Clicking an item triggers an ancestor form's onSubmit handler.

Steps to reproduce the problem

Demo code here.

Problem outline:

1. Wrap an ActionList in a form element with an onSubmit handler.
2. Click an item on the ActionList.

Specifications

• Are you using the React components? (Y/N): Y
• Polaris version number: 2.5.0
• Browser: Chrome Version 67.0.3396.99 (Official Build) (64-bit)
• Device: MacBook Pro
• Operating System: macOS Sierra Version 10.12.6 (16G29)

[tmlayton]

Thanks for the issue @andrewpye. I’ll open an internal issue for this.

[ry5n]

We’ve fixed this internally and it will be available in the next release

[tmlayton]

This is fixed in 2.6.0 👍