Polaris-react: Sketch grid and layout guidance
Issue summary
The Sketch file is a thing of beauty. Thank you for the hard work and inspiration.
Would love to see some more consistency in the spacings.
鈽濓笍 is just one example but found a handful of others.
Would also love to see some guidance as to the grids and guides used. At times spacing was a factor of 10px other times they were factors of 8px.
- Polaris version: v1.0.0
- Sketch version: 43.2
- Device: Mac
- Operating System: macOS Sierra
micahtaylor
>All comments
Thanks for catching this @micahtaylor! We'll do our best to get stuff like this fixed up in an upcoming release.
"Spacing" is on our list of things that we would like to add to the style guide.
For now, we're defaulting to increments of 4px. Exceptions are made however for internal padding within components in order to have the overall height land on a 4px increment.
There are a couple of items that break this rule (slim buttons come to mind) and we'll either make adjustments to those in the future or document those exceptions in the style guide when we add the spacing section.
jessebc
on 23 Apr 2017
Related issues
alex-page
路
3Comments
nemoeric
路
3Comments
danrosenthal
路
3Comments
HYPD
路
3Comments
wmceff
路
3Comments
Most helpful comment
Thanks for catching this @micahtaylor! We'll do our best to get stuff like this fixed up in an upcoming release.
"Spacing" is on our list of things that we would like to add to the style guide.
For now, we're defaulting to increments of 4px. Exceptions are made however for internal padding within components in order to have the overall height land on a 4px increment.
There are a couple of items that break this rule (slim buttons come to mind) and we'll either make adjustments to those in the future or document those exceptions in the style guide when we add the spacing section.