Polaris-react: [Bug] Badge font weights slightly different with new design langauge

Created on 22 Jul 2020  路  3Comments  路  Source: Shopify/polaris-react

Issue summary

While tophatting my color update PR @kyledurand noticed that when using the new design langauge the badge font weights are different for some badges.
https://github.com/Shopify/polaris-react/pull/3127#pullrequestreview-453310526

Expected behavior

Badge font weight should be consistent.

Actual behavior

When looking at the examples the badge font weight is inconsistent.

Steps to reproduce the problem

  1. Open the badge example
  2. Look at the font weights in different browsers

Specifications

  • Are you using the React components? (Y):
  • Polaris version number: 5.0.0
  • Browser: Firefox
  • Device: Macbook
  • Operating System: OSX

All 3 comments

I couldn't reproduce this on a non-Retina external monitor with the latest macOS, Chrome, Firefox. I couldn't reproduce either on the latest Chrome Android on a high dpi screen (Pixel 2 XL).

Page tested: https://5d559397bae39100201eedc1-mmanoiyuuf.chromatic.com/iframe.html?id=all-components-badge--all-examples

The link you shared didn't have the new design language enabled @kaelig just making sure you're testing the right things or maybe we need to update the issue to specify that it's only happening with the new DL enabled @alex-page

Was this page helpful?
0 / 5 - 0 ratings