Pnp-modern-search: Search reverting back to previous search when using pagination

[thebigs1992]

__Remove the above section before submitting, and removal of the below template will result in the issue being closed.__

V3.18.1

When starting a new search having previously searched something and used the pagination it will return to the old search when using pagination with the new search

Steps to reproduce the behavior:

1. Search all
2. Click on Page 2
3. Search for something else (search goes to new search)
4. Go to Page 2 (reverts back to old search)

Expected behavior
Search will continue with new search when on next page

• Browser tested in chrome

[wobba]

I have repro and have to figure out the best approach as it impacts sorting as well.

[wobba]

You can test a fix in the branch https://github.com/microsoft-search/pnp-modern-search/tree/wobba/v3-fixes.

[thebigs1992]

That looks to work a treat, thanks so much :). Will keep testing. Really interesting reading through the code trying to figure out how it all works haha

[wobba]

@thebigs1992 Fixing these things in v3 is not fun as the codebase is not optimal and you patch on patching sort of. The caveat with my fix is that you get two API queries for some user scenarios - but figured that was better to ensure all UX components were in proper sync.