Plyr: ie11 Plyr does not work with slick.js

[ClementThu]

Expected behaviour

Work fine with slick-carrousel

Actual behaviour

After update plyr 2.0.18 to 3.0.0 and +
With slick-carousel : 1.8.1 ( https://github.com/kenwheeler/slick/tree/v1.8.1 )

I find an js error only on ie11:
SCRIPT438: Object does not handle property or find method

This error breaks the js on ie11

It's annoying because I can not add the loop option on the video and it does not work on the tag 2.0.18

Environment

• Browser: ie
• Version:11
• Operating System: windows
• Version:10

Steps to reproduce

• install slick-carousel : 1.8.1 and plyr 3.0.0 and +
  ( no need to included the video on the slider to reproduce, a separate video and a carousel )

[sampotts]

Did you read the docs about polyfilling?

[sampotts]

https://github.com/sampotts/plyr#polyfills

[ClementThu]

Thanks i'm going to look, i do not think my team leader will allow me to use polyfilling

[friday]

There's also an undocumented build with the polyfills bundled (this is arguably worse for performance as it downloads them for everyone, not just for old browsers).

If you're using the cdn the url is https://cdn.plyr.io/3.2.1/plyr.polyfilled.js. If you're using npm it's plyr/dist/plyr.polyfilled.js

[sampotts]

Good point @friday , I should document that build.

[sampotts]

@ClementThu Sounds like you need a new team leader 😆

[ClementThu]

@friday, @sampotts Thank you for your quick reply, i just make a simple test at home. It's works fine with https://cdn.plyr.io/3.2.1/plyr.polyfilled.js With slick or not ... I have not the error plyr undefiened at works. Maybe a polyfill is allready install. At works when i init plyr the slider is broken in ie11. At home without polyfill the slider works fine. I will investigate tomorow.

With the polyfill same error : SCRIPT438: L’objet ne gère pas la propriété ou la méthode « find »
But video and slider works...

We prefer use simple solution without polyfill when it's possible for perf...

@sampotts or not ( i think he will read that 😆 )

[sampotts]

Yeah I'd like to avoid polyfills too but to be able to move forward with better syntax and better performance in 95% of browsers, to support the 5% of people stuck using vintage browsers, we have to use polyfills. You'll find Plyr isn't the only modern JS lib relying on polyfills. Even so, the polyfilled build is ~40kb. By far the best method is to use polyfill.io though as it only serves the polyfills required by that user agent - it's backed by the financial times.

[ClementThu]

My team leader show me a way to clean :
SCRIPT438: L’objet ne gère pas la propriété ou la méthode « find »
Mdn polyfill find