Plyr: local video has poster volume bar be hidden

[louie-senpai]

in mac chrome v70.0.3538.67

[sampotts]

What version of the library? Have you tried with the latest?

[Fromager]

Same for me, in mac chrome too

[louie-senpai]

@sampotts Yes,is latest.

[nmedias]

Same here. Mac/Chrome 70.0.3538.77

[Temperament]

Same here. Chrome.

[sampotts]

Feel free to take a look and open a pull request 👍

[benwick]

The same with Chrome 70.0.3538.110 on Windows...

[Maqsyo]

Same here ♥

[benjasHu]

Same here

[potskhveria]

Same here

[rmamchyk]

Same here Mac/Chrome 75.0.3770.100

[tylerrowsell]

I'm experiencing the same thing. A hidden tag is being added to them. Not sure where it comes from.

It is removed when I scrub on the progress bar though.

My guess it has something to do with this...
https://github.com/sampotts/plyr/blob/95092edc93d713b927c637cefc27945f8537d565/src/js/listeners.js#L381-L385

[zethzeth]

Same here

[sampotts]

Happy to review PRs for this - they're a lot useful than "same here"s 👍 😉.

The problem is that the inverse was originally an issue; a video with no audio showed the volume control. Some logic was added to hide the volume control if no audio track was present. The problem is the browser seems to give flaky results when querying for an audio track. You'll see that there's several events that we check for audio but perhaps we need to add more in there for make up for the crappy browser APIs 🤦‍♂️ It may be that those events fire before the listeners are setup because of the locally loaded video. I'll take another look.

[JeroPizarro]

Hey guys, if you put the preload attribute on your video tag, volume bar appears.

<video preload="none">

It's not a fix but maybe help someone.

[Shaker-Hamdi]

Same issue here as well.

[sihhanwang]

Same issue here as well.
<video preload="none">
not works for me

[kfeng0806]

player.once('canplay', () => player.currentTime = 0);

it's not a fix, but works instead disable video preload.
i hope this can help someone have same issue

[mayeaux]

@sampotts I understand the logic behind the original functionality, but now that we know the browser APIs are sketchy can we just reverse it until we can figure out a more stable way to hide the volume when there's no audio track? I think not having a volume button on a video with sound is more broken than a volume button appearing on a video with no sound, that's my two cents curious to hear your take.

[mayeaux]

Was this ever fixed? This is really broken for me, not being able to change the sound on a video with sound is terrible UX, is this fixed in a newer version or what's the latest version before the change was implemented that caused this? 🤔

[sampotts]

Yes, the logic to hide the volume control has been reverted due to the browser APIs not working as expected. Yes, I'm aware it wasn't great UX but it was temperamental behavior and hard to reproduce. If you want to hide the volume control now (e.g. for videos with no audio track), you have to do so via the controls option.

[sampotts]

See the changelog for v3.5.7:
https://github.com/sampotts/plyr/blob/master/changelog.md#v357

[mayeaux]

Hey np at all, I know browsers can be finicky, overall plyr is great thank you for your work!