Openstreetmap-carto: Add special icon for shop=fabric

[lakedistrictOSM]

https://wiki.openstreetmap.org/wiki/Tag:shop=fabric
7.5k uses

No idea what the icon would look like. I don't think a roll of fabric would work. Any ideas @Tomasz-W?

[Adamant36]

I was just looking for an icon for that last night. Theres some good examples on Noun Project https://thenounproject.com/search/?q=fabric

Also for shop=sewing if you want to create an issue for it to https://thenounproject.com/search/?q=sewing

https://thenounproject.com/search/?q=sewing%20machine

[Tomasz-W]

Icon proposal:
(polka dot pattern)

I'm worried that it looks more like a carpet (we could use it for shop=carpet). I'll try to make a more folded version later (like this: https://cdn2.iconfinder.com/data/icons/industry-3/512/textile-2-512.png), maybe it would be better.

For shop=sewing I propose to use icon proposed for craft=tailor.
See: https://github.com/gravitystorm/openstreetmap-carto/issues/1697#issuecomment-365560281
https://gist.github.com/Tomasz-W/7227fe37f9e4a7e945a977023af84b25

There was also a proposition to use violet version of this icon for shop=tailor.

[lakedistrictOSM]

The sewing machine icon should be saved for shop/craft=tailor. We can design a new icon (probably a needle and thread or cotton reel) for shop=sewing (805) / shop=haberdashery (290) when there's more uses.

[Adamant36]

I kind of like the idea of something like a button with a needle through it and some string for the tailor. They are of touch up people then seamstresses.

[Tomasz-W]

shop=fabric:

• (single roll)
• (double roll)

shop=carpet:

• (no-pattern)
• (zigzag pattern)

shop=sewing:

• (needle + thread)
• (needle + button)

[meased]

The fabric icon looks like paper clips, the carpet icon doesn't really look like anything to me, the sewing icons are good...

However, I don't feel every shop needs a special icon, just the popular or very prominent ones. A violet dot is perfectly fine for shops such as these. I feel the same way about craft rendering, it would be nice if they were rendered, but dots are fine, no need to make a thousand icons.

[lakedistrictOSM]

The fabric icon looks like paper clips, the carpet icon doesn't really look like anything to me, the sewing icons are good...

I suggest that the proposed shop=sewing icon (needle + thread) is used for both shop=fabric and shop=sewing/haberdashery since it's the best icon design.

However, I don't feel every shop needs a special icon, just the popular or very prominent ones.

These recent issues are just about finding icons for the most popular ones, generally above 6k uses.

A violet dot is perfectly fine for shops such as these. I feel the same way about craft rendering, it would be nice if they were rendered, but dots are fine, no need to make a thousand icons.

I'm happy for similar shops to share the same icon. I'm not keen on introducing more dots unless they have a unique colour (like shop and office do).

[dktue]

Vote for needle+button

[Tomasz-W]

Gist links:

• fabric rolls: https://gist.github.com/Tomasz-W/24baa83bbed6e1b56b6d86c54d56579f
• carpets: https://gist.github.com/Tomasz-W/760905dbf57ecf04faf6a527fd9e3397
• sewing: https://gist.github.com/Tomasz-W/1ebdcaec21c3974853710fe9e5695358

[Tomasz-W]

I would like to establish output of discussion here. Which icons do you want for which shops, and which ones we should skip?

[dktue]

I would vote for needle+button for shop=sewig and I don't have an opinion on the icons for shop=carpet and shop=fabric.

[lakedistrictOSM]

I vote for needle + thread for both fabric and sewing/haberdashery, since it's the clearest icon and both shops are similar.

[Tomasz-W]

@kocio-pl Is shop=fabric similar enough to shop=sewing to use the same icon for both? What do you think about it?

[lakedistrictOSM]

Needlecraft shops:
shop=fabric (7.6k uses)
shop=sewing (858 uses)
shop=haberdashery (295 uses)
shop=wool (143 uses)

Nearly 9k collectively

A new issue can be opened to discuss shop=carpet.

[polarbearing]

needle + thread is fine for shop=sewing.
(button is more comprehensive but misunderstood as a smiley)

I'd rather not render shop=haberdashery due to the similarity to shop=sewing (even the wiki says so) to discourage tag fragmentation.

For fabric, the needle+something icons appear unsuitable to me as it fails to show the main article.
I like the roll icons but understand the resemblance to paper clips. Maybe, instead of two rolls, we could have a roll with one more turn?

[Tomasz-W]

• shop=fabric icon proposals with cotton pattern

1)
2)
3)

• for shop=carpet I don't have any better idea than the one proposed earlier (for me, both icons are all readable and intuitive):
  1) (no-pattern)
  2) (zigzag pattern)

[lakedistrictOSM]

We should probably check with the tagging list which of sewing or haberdashery should be supported. (And maybe someone could do a mass edit to change them all, since the wiki definitions are almost identical)

I still prefer needle + thread, and it's worth remembering we use icons that aren't always what a shop mainly sells, eg a cake for confectionery and chocolate shops. What's important is that the icons are easily understood and give some idea about what a shop sells - in this case something to do with sewing.

[polarbearing]

New shop=fabric icon 1 is very convincing from my perspective :-) . The upper part has a weaving which makes clear that it is not stationary (paperclip). Even better than my idea with the extra loop.
No 2 and 3 look more like fences than fabric.

For the carpet, I don't understand the object on the right, maybe it is supposed to be the core the carpet is rolled on, but not intuitive for me.
What about a square that has fringes on all four sides? Just a flat carpet, not rolled.

[Tomasz-W]

@polarbearing Flat carpet version:

[polarbearing]

some square versions:

[Tomasz-W]

For me, it looks like processor icon.

[dktue]

looks definitely like a CPU or a chip in general, to me, too @Tomasz-W, @polarbearing

[polarbearing]

I understand, yes. Focussing on the topic of this issue, can we agree on 'New shop=fabric icon 1' with the webbing? And the needle/thread one for sewing, leaving lesser used tagging for later decision?

[Tomasz-W]

Gist links:

• shop=fabric https://gist.github.com/Tomasz-W/24baa83bbed6e1b56b6d86c54d56579f
• shop=sewing https://gist.github.com/Tomasz-W/1ebdcaec21c3974853710fe9e5695358

[dktue]

I like the pattern-version for shop=fabric and the one with the button for shop=sewing from your last post @Tomasz-W !

[dktue]

Your flat-carpet version looks good, too @Tomasz-W !

[Tomasz-W]

Here is a SVG file with flat carpet if someone would like to test it:

https://gist.github.com/Tomasz-W/760905dbf57ecf04faf6a527fd9e3397

[Adamant36]

shop sewing (needle + thread)

shop sewing (needle + button)

shop fabric (pattern)

shop fabric (1 roll)

carpet (zigzag)

carpet (no-pattern)

carpet (flat)

[kocio-pl]

My votes are:

• shop sewing (needle + thread)
• shop fabric (1 roll)
• carpet (flat)

[Tomasz-W]

• sewing -> needle + thread
• fabric -> I'll provide pattern-only icon, because rolls are not intuitive imo

@Adamant36 I think something went wrong with carpets icons (https://gist.github.com/Tomasz-W/760905dbf57ecf04faf6a527fd9e3397) , there was a space between rolled and unrolled parts of it, and on the test renderings they seem to be joined together.

[Tomasz-W]

shop=fabric (pattern-only):

Gist link: https://gist.github.com/Tomasz-W/24baa83bbed6e1b56b6d86c54d56579f

[polarbearing]

I somehow liked the pattern+roll no 1 from Aug 27, but I can also agree with today's pattern-only.

[lakedistrictOSM]

My favourites:
sewing: needle + thread
fabric: needle + thread
carpet: flat/zig zag roll

The proposed fabric icon looks too much like a paper clip (and might get confused with stationery shops)

[dktue]

pattern-only works fine for me. 👍

[Tomasz-W]

@Adamant36 There was an error in carpet icon, but I fixed it. Can you test zig-zag version for shop=carpet once more? https://gist.github.com/Tomasz-W/760905dbf57ecf04faf6a527fd9e3397#file-shop-carpet-zigzag-svg

[Adamant36]

@Tomasz-W, yeah. Thanks for reminding me. I just got busy. I'll probably do it this weekend sometime.

[Adamant36]

carpet (zig-zag)

carpet (no-pattern)

carpet (flat)

Personally, I like carpet zig-zag. Carpet no pattern still has the problem. If you want to fix it even if we aren't going with it in case someone in the future wants to use it for their own style that would be cool.

Fabric pattern

personally, I prefer fabric roll or fabric roll with pattern.

[Tomasz-W]

@Adamant36 Basing on whole disscussion above, I would go with:

• shop=carpet -> zig-zag roll
• shop=fabric -> pattern + roll
• shop=sewing -> needle + thread