Openstreetmap-carto: Strange rendering of amenity=toilets as a brown circle at zoom level 19

[ghost]

Since the last update (v4.7.0), amenity=toilets are rendered as a brown circle instead of the toilets symbol at zoom level 19 (but not at zoom levels 17–18):

I suspect this to be a bug, because I couldn't fine a reference in the change log (and this change doesn't seem to make sense).

[kocio-pl]

Could you post a link to this location? Otherwise it'd be hard to investigate it.

[ghost]

The screenshot was from here:

• https://www.openstreetmap.org/node/5141331468

but it seems to affect all amenity=toilets.

[kocio-pl]

I don't see this effect wnywhere. Could you post which rendering server are you being served by?: http://tile.openstreetmap.org/cgi-bin/debug

Mine is orm.openstreetmap.org .

[geowas-github]

Same with playgrounds:
https://www.openstreetmap.org/#map=19/49.99088/8.27042

Unfortunately I have just redrawn the plaground, so probably you won't see it any more.

[kocio-pl]

Please also report which server did such rendering, I suspect this the source of the problem.

[geowas-github]

How do I see this?

[kocio-pl]

Through the link I included:

http://tile.openstreetmap.org/cgi-bin/debug

[geowas-github]

orm.openstreetmap.org

[kocio-pl]

I have seen this just for a moment with orm, but now it's gone. I will check it again tomorrow.

[ghost]

I don't see this effect wnywhere. Could you post which rendering server are you being served by?: http://tile.openstreetmap.org/cgi-bin/debug

scorch.openstreetmap.org

There are even leisure=pitch + sport=table_tennis nodes rendered as brown circle:

Location: https://www.openstreetmap.org/node/5148254822

[alexander-ii]

Same thing with the access=permissive + barrier=gate.
Link to node history

[jragusa]

For the record, bicycle_parking at z=19 is also concerned but surprisingly, not all are modified (related to the cache?). At z=18, the correct icon appears.

Example : https://www.openstreetmap.org/node/4693394595

z=18

z=19

[kocio-pl]

Looks like a real style bug, I guess v4.7.1 would be needed soon...

So the first thing is to find the faulty commit.

[zerebubuth]

Might it be related to the entrances query?

        (SELECT
            way,
            tags->'entrance' AS entrance,
            access
          FROM planet_osm_point
          WHERE tags->'indoor' = 'no'
            OR tags->'indoor' IS NULL)
         AS entrances

Seems very general to me, and this block in entrances seems to only filter on the access tag:

#entrances {
  ...
 [zoom >= 19] {
    ...
    ["access" = "yes"],
    ["access" = "permissive"] {
      marker-fill: @entrance-permissive;
    }
    ["access" = "no"] {
      marker-fill: @entrance-normal;
      marker-file: url('symbols/rectdiag.svg');
    }
  }
  ...
}

[kocio-pl]

This was my primary suspect, thanks for taking a look at it!

In case this is a real reason, the question is if it can be fixed soon ( @tpikonen ?) or it should be just reverted?

[jragusa]

I confirm that the access tag is responsible of the bug because bicycle_parking without this tag are correctly rendered.

[tpikonen]

Yes, the bug is where @zerebubuth indicated. I'll prepare a PR soon.

[tpikonen]

Ok, please test PR #3048 if you can. Entrances and toilets with permissive access now render correctly here, but it would be nice to get a confirmation.