I think it will make sense to setup auto-deployments for each PR, changes will then be more easily and quickly seen, no need to pull them over and run each time.
NA
It will be more convenient to review UI changes. Netlify is simple enough to setup and performs well. Any collaborator can just add the repo on Netlify and enable the PR comment hook. :)
This is already here with /gcbrun you can create a staging link for the PR.
Works well, would be even better to fully automate it rather than requesting a build everytime and creating unnecessary noise, maybe we should experiment with Netlify.
Closing ✨
@benhalverson I think we want to use this thread to discuss netlify and reopen as the team decides.
@anshumanv thank you for initially opening this before we all made it to the party :)
/cc @nodejs/nodejs-dev
So I'll reopen this issue.
Here are a few loose threads:
Awesome @SMotaal, let me know if I can contribute in any way. Happy to help! 😄
Awesome @SMotaal, let me know if I can contribute in any way. Happy to help! 😄
Great @anshumanv , maybe swing by the next meeting. We will discuss details :]
Great @anshumanv , maybe swing by the next meeting. We will discuss details :]
Sounds good! Would appreciate if you can direct me to the meeting link when it happens. :)
Great @anshumanv , maybe swing by the next meeting. We will discuss details :]
Sounds good! Would appreciate if you can direct me to the meeting link when it happens. :)
We've a public calendar. You can check all the events here -> https://nodejs.org/calendar
There will be also a dedicated issue 3 days before the meeting. Looking forward... :]
I think this can be closed with the work done in #661
Most helpful comment
@benhalverson I think we want to use this thread to discuss netlify and reopen as the team decides.
@anshumanv thank you for initially opening this before we all made it to the party :)
/cc @nodejs/nodejs-dev