Nodejs.dev: Discussion: report code coverage during travis builds

Created on 27 Mar 2019  路  3Comments  路  Source: nodejs/nodejs.dev

Summary

I'm proposing that we should report code coverage during the Travis build process. In my opinion Coveralls is a great option which integrates really well with Travis.

What are your thoughts on this?

Motivation

  • Even though the code base is currently a bit of a WIP (and some decrease in coverage will naturally occur), this will promote writing tests when adding new functionality.
  • In the long run, this will help PR-reviewers to detect cases when coverage is decreased and some additional tests might have to be added before merging.

Most helpful comment

Hey Olle! After a very quick discussion in the meeting today we're all +1 on this! Want to tackle adding it? 馃檪

Also, welcome to the Website Redesign repo!

All 3 comments

Hey Olle! After a very quick discussion in the meeting today we're all +1 on this! Want to tackle adding it? 馃檪

Also, welcome to the Website Redesign repo!

Thanks, @amiller-gh! Unfortunately, I wasn't able to listen in on the meeting (will try to join in next time) but thanks for discussing this. Will pick this up during the weekend 馃檪

Closed #211 馃帀

Was this page helpful?
0 / 5 - 0 ratings

Related issues

benhalverson picture benhalverson  路  4Comments

giankotarola picture giankotarola  路  4Comments

benhalverson picture benhalverson  路  4Comments

lidoravitan picture lidoravitan  路  4Comments

mmarchini picture mmarchini  路  4Comments