While trying the fix with emotion in #162 and looking at emotion doc, found out that v10 is the latest version for `emotion, and there's this Migrating to Emotion 10 to support the effort.
Wondering your thoughts about any benefits to migrate to emotion 10 for this project?
BeniCheni
All 4 comments
Other than your fix, I don't think we've leveraged emotion as of yet in the codebase (I could be wrong, though).
I see no harm in upgrading to the latest.
Thoughts @LaRuaNa @ollelauribostrom?
sagirk
on 3 Mar 2019
In the actual code there is no emotion used. So we can update to the latest version and migrate couple of lines CSS we have to emotion. Wanna open a PR @BeniCheni ? :]
LaRuaNa
on 3 Mar 2019
@LaRuaNa, #162 tries out emotion in its fix. I can look out for other CSS to adapt emotion as I see fit in the migration. Happy to try a PR.
BeniCheni
on 3 Mar 2019
172 was merged.
BeniCheni
on 7 Mar 2019
Related issues
jemjam
路
3Comments
benhalverson
路
4Comments
antsmartian
路
3Comments
mmarchini
路
4Comments
designMoreWeb
路
3Comments
Most helpful comment
@LaRuaNa, #162 tries out emotion in its fix. I can look out for other CSS to adapt emotion as I see fit in the migration. Happy to try a PR.