@potch is taking this one – will let him flesh out the ticket.
The big question here is whether how best and where to code the glitch project embeds. The options that present themselves in order of increasing complexity are:
I'll likely start by forking the docs repo and doing inline, just to act as a source of truth, but am very open to adapting if others have ideas.
@potch
The big question here is whether how best and where to code the glitch project embeds. The options that present themselves in order of increasing complexity are:
* Into the docs themselves, just replacing code blocks with the embed <iframe>I don’t know if we really want to replace code blocks with naked iframes. That would cost a lot of requests especially if they are not loading on demand. Not the best for UX.
* Into a fork/branch of the docs used specifically for this project- preserves existing data
If I understand you correctly that means we need to split the docs? I think splitting docs from code is generally not a good choice. Since you need to make changes at two different places maintenance gets more complicated. BTW if i remember correctly we wanna pull docs from node Repo. Please correct me if I'm wrong.
* Insert glitch references into the docs, turning them into embeds at build time (not sure exactly how this would work, maybe just a sentinel comment or something?) Does gatsby allow for embed markup? * generated dynamically from marked code samples (there's no way this will be doable by deadline, but I want to call it out because we're pursuing it on the glitch as a future feature)
IMO the combination of last two suggestions is best way to do it. Gatsby allows embed markups though i couldn't find a plugin for Glitch embeds but I consent to help with that.
Biggest advantage about dynamically generated sample codes at glitch side would be, it will be easier to maintain. We don't need to update nothing extra than samples in our docs. I think we can easily solve the problem about request overhead with a embed plugin for Gatsby as well. While loading iframes on demand.
I'll likely start by forking the docs repo and doing inline, just to act as a source of truth, but am very open to adapting if others have ideas.
@amiller-gh @MylesBorins @argyleink are you okay with iframes in the short term? I know they're not ideal, but I'm sensitive to our fast-approaching deadline.
I'm personally fine with iframes in the short term to hit the deadline, but let's sync again on the long-term solution and track against it over the next month or so!
Let's use this issue to track short-term integration. Want to open up a new issue to hash out the long term implementation, RFC style?
@amiller-gh that's a good idea, will open a long-term integration issue.
Here's a screenshot of an embed in action:

Thanks for the work on this potch
Most helpful comment
Here's a screenshot of an embed in action: