News: Nextcloud 13 Blockers

[BernhardPosselt]

• [x] Navigation keys are broken due to position: relative on #app-content-wrapper
• [x] Compact mode is broken due to display: flex on #app-content-wrapper
• [x] Feed headlines have a text-decoration: underline due to added styles for a.external which conflict with our own rules
• [x] News content does not span the whole width anymore with position: static (see border bottom of earch article)
• [ ] Unread count is hidden if feed title is long, e.g.:

This prevents a release on Nextcloud 13 and I've pulled 12.0.0 due to more issues surfacing recently which I won't be fixing due to #150

[skjnldsv]

• Unread count is hidden if feed title is long, e.g.:
  Not on my stable13 server:
  

[skjnldsv]

@BernhardPosselt can you point me where the compact view is broken?
Also, should we support 13+ on the next release?

[BernhardPosselt]

Hover over the settings area

[BernhardPosselt]

Unread count is hidden if feed title is long, e.g.:
Not on my stable13 server

Is not fixed, reopening

[BernhardPosselt]

@skjnldsv add bemetal.org into a folder

[skjnldsv]

@BernhardPosselt still good on my side... :/

[BernhardPosselt]

@skjnldsv not the only one with this issue :) https://github.com/nextcloud/news/issues/234#issuecomment-360983544

[BernhardPosselt]

Also it seems to only affect Firefox, looks good in Chrome

[skjnldsv]

Thanks, I'll try on ff :)

[MorrisJobke]

Fixed in 13.0.0 RC 4

[onny]

Thanks for working on this issue.
Now I'm Nextcloud 13 RC4 and the latest git master of the news app, but the bug described here https://github.com/nextcloud/news/issues/234#issuecomment-360983544 is still present. Invisible feeds are still filling additional space in the list :(

[skjnldsv]

@onny what browser?

[onny]

Firefox and Chrome

[BernhardPosselt]

Try clearing your browser cache

[skjnldsv]

Yup, can't reproduce either :)

[onny]

That's how you can reproduce it using a Docker image with a fresh Nextcloud instance:

cd /tmp
wget "https://github.com/nextcloud/news/releases/download/12.0.1/news.tar.gz"
wget "https://onny.project-insanity.org/files/oc_news_db.tar.gz"
tar xvf news.tar.gz oc_news_db.tar.gz
docker build -t nextcloud-testing github.com/onny/docker-nextcloud
docker run -v /tmp/dockerdata:/data/data -v /tmp/news:/opt/nextcloud/apps/news -d --name nextcloud -p 80:80 nextcloud-testing

• Visit http://localhost:80 and create admin account called "onny" and start a fresh Nextcloud instance
• Enable app "News"

Import news app db backup:

cat /tmp/oc_news_{feeds,folders}.sql | sudo sqlite3 /tmp/dockerdata/owncloud.db

Now wait until Webcron will start loading the feeds. The hidden items will appear.

[onny]

Updated to Nextcloud 13.0 final and this issue is still present :(

[skjnldsv]

@rullzer is the appdata clear function available for @onny ?

[rullzer]

Not in 13 yet. But you can try https://github.com/rullzer/appdatacleaner

[onny]

So I cleaned up my feed directory and of course it solved the issue. It's not the best soloution but maybe the quickest ;) Thanks for helping!