News: Feeds where assets are led with // are erroneously prefixed with the domain base URL

Created on 14 May 2020  路  4Comments  路  Source: nextcloud/news

Explain the Problem

In 14.1.7 feeds where assets (such as images) are led with // (instead of http:// or https://) will be erroneously prefixed with the domain base URL (i.e. https://domain.tld//domain.tld/path/to/asset).

The issue does not exist in 14.1.6.

Steps to Reproduce

Explain what you did to encounter the issue

  1. Find a feed where assets are prefixed with // (sorry, I can't provide the feed that has the error)
  2. Load feed in to News app
  3. Note that assets don't load and instead will place the base domain before the // (i.e. https://domain.tld//domain.tld/path/to/asset)

System Information

  • News app version: 14.1.7
  • Nextcloud version: 18.0.4
  • Cron type: Cron
  • PHP version: 7.4.5
  • Database and version: MariaDB v10.4.12
  • Browser and version: Firefox 76.0.1
  • Distribution and version: Arch Linux (rolling)

Contents of nextcloud/data/nextcloud.log

There are no errors in there that pertain to this issue.

Contents of Browser Error Console

There are no errors in there that pertain to this issue.

bug

Most helpful comment

v4.6.2 fixes it

All 4 comments

@alexdebril any idea?

Yes, It's my fault. When implementing the relative to absolute URL transformation, I assumed that no one would use // instead of the http:// or https:// scheme ...
I'll prepare a patch very soon to fix this.

Really sorry for that :(

v4.6.2 fixes it

Thanks @alexdebril
Fix included in 14.1.8

Was this page helpful?
0 / 5 - 0 ratings