News: News feed doesn't successfully update (since NC 20?)

[siccovansas]

IMPORTANT

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

• [x] I have read the CONTRIBUTING.md and followed the provided tips

Explain the Problem

News doesn't update any more and I think this started when I updated to Nextcloud 20. The only relevant thing I could find about this problem is the error in nextcloud.log which I pasted below. This happens every 5 minutes.

I have no clue what is going wrong, but am happy to help debug it :)!

Steps to Reproduce

Explain what you did to encounter the issue

1. Use News on Nextcloud 20
2. Don't receive any news messages in the News feed

System Information

• News app version: 15.0.4
• Nextcloud version: 20
• Cron type: system cron (docker)
• PHP version: 7.4.11
• Database and version: Postgresql 12.4
• Browser and version: Firefox 81.0
• Distribution and version: Ubuntu 20.04

Contents of nextcloud/data/nextcloud.log

{"reqId":"R669CUNNhGHeblSpKQyS","level":3,"time":"2020-10-12T11:35:01+00:00","remoteAddr":"","user":"--","app":"core","method":"","url":"--","message":{"Exception":"TypeError","Message":"Argument 1 passed to OCA\\News\\Fetcher\\FeedFetcher::decodeTwice() must be of the type string, null given, called in /var/www/html/custom_apps/news/lib/Fetcher/FeedFetcher.php on line 254","Code":0,"Trace":[{"file":"/var/www/html/custom_apps/news/lib/Fetcher/FeedFetcher.php","line":254,"function":"decodeTwice","class":"OCA\\News\\Fetcher\\FeedFetcher","type":"->","args":[null]},{"file":"/var/www/html/custom_apps/news/lib/Fetcher/FeedFetcher.php","line":160,"function":"buildItem","class":"OCA\\News\\Fetcher\\FeedFetcher","type":"->","args":[{"__class__":"FeedIo\\Feed\\Item"},null,false]},{"file":"/var/www/html/custom_apps/news/lib/Service/FeedServiceV2.php","line":274,"function":"fetch","class":"OCA\\News\\Fetcher\\FeedFetcher","type":"->","args":["https://www.zylstra.org/blog/feed/",false,"Tue, 06 Oct 2020 07:25:25 +0000",false,null,null]},{"file":"/var/www/html/custom_apps/news/lib/Service/FeedServiceV2.php","line":338,"function":"fetch","class":"OCA\\News\\Service\\FeedServiceV2","type":"->","args":[{"items":[],"id":25,"__class__":"OCA\\News\\Db\\Feed"}]},{"file":"/var/www/html/custom_apps/news/lib/Service/UpdaterService.php","line":55,"function":"fetchAll","class":"OCA\\News\\Service\\FeedServiceV2","type":"->","args":[]},{"file":"/var/www/html/custom_apps/news/lib/Cron/UpdaterJob.php","line":68,"function":"update","class":"OCA\\News\\Service\\UpdaterService","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/html/lib/private/BackgroundJob/Job.php","line":52,"function":"run","class":"OCA\\News\\Cron\\UpdaterJob","type":"->","args":[null]},{"file":"/var/www/html/lib/private/BackgroundJob/TimedJob.php","line":59,"function":"execute","class":"OC\\BackgroundJob\\Job","type":"->","args":[{"__class__":"OC\\BackgroundJob\\JobList"},{"__class__":"OC\\Log"}]},{"file":"/var/www/html/cron.php","line":126,"function":"execute","class":"OC\\BackgroundJob\\TimedJob","type":"->","args":[{"__class__":"OC\\BackgroundJob\\JobList"},{"__class__":"OC\\Log"}]}],"File":"/var/www/html/custom_apps/news/lib/Fetcher/FeedFetcher.php","Line":179,"CustomMessage":"Error while running background job (class: OCA\\News\\Cron\\UpdaterJob, arguments: )"},"userAgent":"--","version":"20.0.0.9","id":"5f8442f950dab"}

[holzhannes]

I can confirm this since NC 20 Update, I didn´t receive any new feed content.

[siccovansas]

Thanks for quickly adding a fix with #869 :smiley: ! I see that a new 15.0.5 release was created 2 days ago, but this isn't available yet in Nextcloud's app store. Is something blocking it? I would love to test if the fix solves this issue :+1: Thanks again :100:

[siccovansas]

@SMillerDev @Grotax it seems that in appinfo/info.xml of the 15.0.5 release the version number was not updated from 15.0.4 to 15.0.5. I changed that and manually updated the news app (though the news icon in the navbar is not loading correctly now, might be a caching thing). I can confirm #869 fixes this issue, thanks!

[Grotax]

@siccovansas I know we are working on automating the release so that stuff like this doesn't happen anymore

[varac]

Can't you just push 15.0.5 to the app store manually please ? I'm cut off from updated news for around 2 weeks now.
Thanks !

[Grotax]

No at the moment that's not possible anymore you need to wait for the next release 15.0.5 is a broken release.
And I'm sorry that news is not working for you but keep in mind real people with normal jobs and other things in life invest real time here.

And I could suggest you now to help us but I know that very likely that triggers:

• I don't have time
• I'm not good enough at php
  And others.

So please, open source is not a service culture where a service is offered and when it's not working you can complain and ask for a compensation. Check our license if you don't like that argument.

And don't take it personally but we read that so many times, can't you do this or can't you do that and I'm tried of it.

[Grotax]

News 15.0.6 should be available in the store soon.