Manageiq-ui-classic: Semi-redundant check all checkboxes for C&U collection trees

Created on 26 Mar 2020  路  4Comments  路  Source: ManageIQ/manageiq-ui-classic

Do we need these Check all checkboxes for the two trees? The switch above basically does the exact same thing. Removing the checkboxes would simplify code complexity by a lot.

Screenshot from 2020-03-26 13-04-25

cleanup question settings

Most helpful comment

@skateman let's get rid of "Check All" checkboxes since they are doing the same thing as the switch above them.

All 4 comments

@miq-bot add_label question, cleanup

@skateman let's get rid of "Check All" checkboxes since they are doing the same thing as the switch above them.

@skateman when i toggle the switch back to "No" it does not uncheck all the items in the tree, which is what "Check All" checkbox used to do, with the change in this PR user will have to manually check/uncheck the items if they want to check/uncheck them all.
Let's keep a note of this and if needed, we can add Check All checkbox back once trees are converted to React.

Just saw this, but yeah, Check All is more of a convenience for checking everything so you can then uncheck individual items (or vice versa, to uncheck all boxes so you can then check individual items).

Was this page helpful?
0 / 5 - 0 ratings

Related issues

hstastna picture hstastna  路  9Comments

epwinchell picture epwinchell  路  5Comments

hstastna picture hstastna  路  5Comments

moolitayer picture moolitayer  路  5Comments

miha-plesko picture miha-plesko  路  6Comments