Manageiq-ui-classic: Toolbar simplification

Created on 5 Aug 2019  路  5Comments  路  Source: ManageIQ/manageiq-ui-classic

Currently, we display an icon for each toolbar group. This predates the implementation of Patternfly and contributes to the real estate problem experienced in the toolbars. For example: we have never had room in the toolbar to add filtering/search and have significant wrapping at some resolutions.

PF3 & PF4 examples use icons very sparingly:
https://www.patternfly.org/v3/pattern-library/forms-and-controls/toolbar/
https://www.patternfly.org/v4/documentation/core/components/toolbar

I would like to suggest that we remove all top level icons when text is also present, with the exception of custom button groups.

Before
Screen Shot 2019-08-05 at 9 54 39 AM

After
Screen Shot 2019-08-05 at 9 50 35 AM

Implementing: https://github.com/ManageIQ/manageiq-ui-classic/issues/5892 will also help a lot.

uapproved

Most helpful comment

First impression: this makes the toolbars confusing, suddenly every button is the same

I would not go so far as to claim we should only keep the icons, not the text,
but I do think the icons are what people distinguish the options by.
(The text is still useful the first few times, when searching, etc.)

All 5 comments

@Loicavenel @terezanovotna @martinpovolny

This is a great idea @epwinchell. This is going to make this toolbar much more simple.

@miq-bot add_label ux/approved

First impression: this makes the toolbars confusing, suddenly every button is the same

I would not go so far as to claim we should only keep the icons, not the text,
but I do think the icons are what people distinguish the options by.
(The text is still useful the first few times, when searching, etc.)

Was this page helpful?
0 / 5 - 0 ratings