Manageiq-ui-classic: Need to identify invalid catalog items/bundles in the UI

[miq-bot]

Related to changes made in PR #2947

Catalog items that directly link to provision templates can become invalid if the associated VM template becomes archive, orphaned or deleted from the provider. The backend has been modified so a user can edit the items and correct the issue by selecting a new template.

The UI needs to be updated to make it easy to identify the catalog items that need to be updated.

Suggested UI changes:

1. Invalid catalog items should be flagged in the Catalog Items accordion so they can be identified by the administrators. We can add a boolean column to the list view for Template Valid Status. We will look into a visualization for the tree and quad icons.
2. Catalog bundles that include invalid catalog items should be flagged. When a bundle or item is selected, show a warning flash message such as "Cannot be ordered: < error returned by the template_valid_error_message method >".
3. Service ordering screen (Service Catalogs accordion) should flag or hide invalid items (probably hide them as the end user can't order them anyway).

---

This issue was moved to this repository from https://github.com/ManageIQ/manageiq/issues/3197, originally opened by @gmcculloug

[h-kataria]

@hstastna please see my comment https://github.com/ManageIQ/manageiq/issues/3197#issuecomment-544679068

[hstastna]

@h-kataria I would like to start working on this issue. But I have no information _how_ to distinguish between valid and invalid items. It there any PR already done regarding it?
Also I think that UX should decide how and where we would display the Note on the Item/bundle details view, if the item is invalid. I can see many possibilities how to achieve it. I can't find any suggestions already made regarding this. Do we have any? Thank you :sparkle:

[gmcculloug]

@hstastna Backend changes were added in https://github.com/ManageIQ/manageiq/pull/3247 by @lfu. Note: That PR was implemented a while ago so please let us know if you see any issues with it. Also important to note that the template_valid? method can be an expensive call so will want to be careful with how this gets implemented in the UI.

[h-kataria]

@hstastna it seems @lfu added backend support for invalid template, you should be able to call template_valid? to find out if a ServiceTemplate is invalid. @lgalis had started doing some work on this in https://github.com/ManageIQ/manageiq/pull/4415 you may want to check that out. I think all we need is a flash warning message on the top of summary screen if a selected record is invalid.

1. We should add a new column template_valid? in the list view to display whether the item/bundle is valid or not.
2. We should display the Note on the Item/bundle details view, IF the item is invalid.
3. We should make Order button disabled for any invalid items with a hover text, that's being returned from backend.

[hstastna]

I've created a PR https://github.com/ManageIQ/manageiq-ui-classic/pull/6448 to identify invalid catalog items/bundles in the UI.

[hstastna]

@himdel @h-kataria I think this issue can be closed. Thank you :sparkle:

[h-kataria]

Fixed in https://github.com/ManageIQ/manageiq-ui-classic/pull/6448 and https://github.com/ManageIQ/manageiq-decorators/pull/26