Manageiq-ui-classic: Cloud Intel -> Report -> Dashboard -> all tree menus don't work

[lpichler]

only upstream
GIF:

@miq-bot add_label bug

[lpichler]

@himdel @ZitaNemeckova @skateman

[himdel]

@lpichler What does it mean? What do you expect to happen that doesn't?

Can't tell anything from the screenshot or the title..

[lpichler]

all menus in dashboard accordion don't work, they display somehow previous screen displayed screen.

and it should be gif, where should be visible whole scenario. can you see GIF or just screenshot ?

[lpichler]

@himdel if you don't know what it caused(by any recent work), I can look for commit.

[himdel]

I can see a gif, but .. it's just clicking around, no errors anywhere.

So.. I need to go to Cloud Intel > Report,
switch to the Dashboard accordion,
and ... find a menu that doesn't work?
Somewhere in the toolbars?

Any exceptions during that?

[lpichler]

I am sorry I provided uncompleted information.

When I clicked on Dashboard -> All .. -> Default dashboard

 Error caught: [NoMethodError] undefined method `first' for nil:NilClass
/Users/liborpichler/manageiq/manageiq-ui-classic/app/controllers/report_controller/widgets.rb:278:in `widget_get_node_info'
/Users/liborpichler/manageiq/manageiq-ui-classic/app/controllers/report_controller.rb:419:in `determine_xx_node_info'
/Users/liborpichler/manageiq/manageiq-ui-classic/app/controllers/report_controller.rb:523:in `get_node_info'
/Users/liborpichler/manageiq/manageiq-ui-classic/app/controllers/report_controller.rb:634:in `replace_right_cell'
/Users/liborpichler/manageiq/manageiq-ui-classic/app/controllers/report_controller.rb:197:in `tree_select'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/abstract_controller/base.rb:188:in `process_action'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_controller/metal/rendering.rb:30:in `process_action'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/abstract_controller/callbacks.rb:20:in `block in process_action'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/callbacks.rb:126:in `call'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/callbacks.rb:506:in `block (2 levels) in compile'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/callbacks.rb:455:in `call'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/callbacks.rb:101:in `__run_callbacks__'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/callbacks.rb:750:in `_run_process_action_callbacks'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/callbacks.rb:90:in `run_callbacks'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/abstract_controller/callbacks.rb:19:in `process_action'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_controller/metal/rescue.rb:20:in `process_action'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/notifications.rb:164:in `block in instrument'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/notifications.rb:164:in `instrument'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_controller/metal/params_wrapper.rb:248:in `process_action'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activerecord-5.0.7.1/lib/active_record/railties/controller_runtime.rb:18:in `process_action'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/abstract_controller/base.rb:126:in `process'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionview-5.0.7.1/lib/action_view/rendering.rb:30:in `process'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_controller/metal.rb:190:in `dispatch'
/Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.

and there is GIF how it should work:

[lpichler]

reproduction steps:

1. Cloud Intel -> Reports (But it cloud be any dashboard)
2. Go to Dashboard (this section is not loaded, but last section stayed here)

[himdel]

Ooh, so, clicking on tree items in the Dashboards accordion is rendering the wrong thing on the right side?

Looks like it is working for me...

Can you try again please, and also catch the GET request? (Looking for params.)

[lpichler]

I got latest code. (issue is still here) this behaviour was not only on my machine.

I was on Schedule accordion:

then I clicked on Dashboard accordion:
tree menu All Dashboard:
http://localhost:3000/report/accordion_select?id=db_accord
tree menu Default Dashboard
http://localhost:3000/report/tree_select?id=xx-16

is it what did you looking for ?

[himdel]

Aah, looks like Schedules are part of the problem.

I can never reproduce this when going to Dashboards directly after login (well, via Saved Reports which are the default).

But, when switching from the schedules accordion to dashboard, I'm seeing...

[----] I, [2019-01-14T15:45:15.547468 #15136:2ae00992f52c]  INFO -- : Started POST "/report/accordion_select?id=db_accord" for ::1 at 2019-01-14 15:45:15 +0000
[----] I, [2019-01-14T15:45:15.581739 #15136:2ae00992f52c]  INFO -- : Processing by ReportController#accordion_select as JS
[----] I, [2019-01-14T15:45:15.581863 #15136:2ae00992f52c]  INFO -- :   Parameters: {"id"=>"db_accord"}
...
 FATAL -- : Error caught: [NoMethodError] undefined method `read_only' for nil:NilClass
/home/himdel/manageiq-ui-classic/app/helpers/application_helper/button/db_delete.rb:3:in `disabled?'
/home/himdel/manageiq-ui-classic/app/helpers/application_helper/button/basic.rb:50:in `calculate_properties'
/home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:150:in `apply_common_props'
/home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:82:in `toolbar_button'
/home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:99:in `block in build_select_button'
/home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:94:in `each'
/home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:94:in `each_with_index'
/home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:94:in `build_select_button'
/home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:190:in `build_button'
/home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:459:in `block (2 levels) in build_toolbar_from_class'
/home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:458:in `each'
/home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:458:in `block in build_toolbar_from_class'
/home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:453:in `each'
/home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:453:in `each_with_index'
/home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:453:in `build_toolbar_from_class'
/home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:20:in `build_toolbar'
/home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:7:in `call'
/home/himdel/manageiq-ui-classic/app/helpers/application_helper.rb:477:in `build_toolbar'
/home/himdel/manageiq-ui-classic/app/controllers/report_controller.rb:662:in `replace_right_cell'
/home/himdel/manageiq-ui-classic/app/controllers/report_controller.rb:169:in `accordion_select'

After that,
I can click on things in the dashboard tree, but the right side will show "Choose a Schedule to view from the menus on the left."

So, sounds like in some cases, switching the accordion fails, and leaves the UI in a weird state.

Are you seeing the same thing @lpichler ? (Mentions of schedule on the right side, when in dashboard.)

[lpichler]

I can never reproduce this when going to Dashboards directly after login (well, via Saved Reports which are the default).

for me,
I can reproduce it every time, independently which accordion I visited before.

when I client to menu in tree I see error here otherwise the error what did you post.

Are you seeing the same thing @lpichler ? (Mentions of schedule on the right side, when in dashboard.)

Yes, in addition I see the screen what visited before.

[himdel]

Hopefully #5162 will fix both problems..