Manageiq-ui-classic: Host → Vm list misbehaviour

[romanblanco]

first, go to Compute → Infrastructure → Hosts / Nodes.

After trying to Clone some of the VMs in the list, I'm getting an error

[----] F, [2018-09-06T13:23:45.388803 #13151:2b2814244fc0] FATAL -- : Error caught: [ActionView::Template::
Error] undefined method `[]' for nil:NilClass
/home/rblanco/devel/manageiq-ui-classic/app/views/layouts/listnav/_show_list.html.haml:20:in `block (2 leve
ls) in __home_rblanco_devel_manageiq_ui_classic_app_views_layouts_listnav__show_list_html_haml__6030010248$
9234679_70171299217740'
/home/rblanco/devel/manageiq-ui-classic/app/views/layouts/listnav/_show_list.html.haml:11:in `each'
/home/rblanco/devel/manageiq-ui-classic/app/views/layouts/listnav/_show_list.html.haml:11:in `block in __ho
me_rblanco_devel_manageiq_ui_classic_app_views_layouts_listnav__show_list_html_haml__603001024859234679_701
71299217740'

I've tried a simple fix in the _show_list template:

-            - if (!@default_search.blank? && @default_search.name == search.name) || (@default_search.blank? && search.id.to_i.zero? && settings_default('0', :default_search, @edit[@expkey][:exp_model].to_s.to_sym).to_s == '0')
+            - if @edit.present? && (!@default_search.blank? && @default_search.name == search.name) || (@default_search.blank? && search.id.to_i.zero? && settings_default('0', :default_search, @edit&.dig(@expkey, :exp_model).to_s.to_sym).to_s == '0')

Now, the error does not appear, but the behaviour of the list is incorrect.

After running the Clone action for a VM in the list, the list is refreshed but with Hosts.
Running any operation now ends with an error Can't access selected records, as we're trying to look for a VM by Host's ID:

[romanblanco]

@miq-bot add_label bug

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

[hstastna]

Update:
_Clone_ action works, we're not trying to look for a VM by Host's ID. It looks like Romans suggested fix will be enough to do regarding this issue. Another possibility is refactoring button method in _host_controller.rb_.

[romanblanco]

@hstastna can you take over and create a PR with the suggested fix?

[hstastna]

@romanblanco I am not sure because probably refactoring host controller and then eventually fixing this issue could be better, comparing to adding extra conditions to the haml or anywhere else.

[romanblanco]

@hstastna let me know if I can help

[hstastna]

After discussion with @martinpovolny, we've decided to add Roman's suggested fix and also to refactor app/views/layouts/listnav/_show_list.html.haml, and eventually later also host controller.

[hstastna]

@romanblanco I think we can close the issue, fixed by https://github.com/ManageIQ/manageiq-ui-classic/pull/6588. Thank you :)