Manageiq-ui-classic: SSA and Container Builds: nothing happens in the UI

[hstastna]

There is an issue regarding _Container Builds_: it is not clear if SmartState Analysis was initiated, no flash message present, nothing happens in the UI, also toolbar remains open.

Steps to reproduce:

1. _Compute > Containers > Container Builds_
2. Check some item(s) in the list
3. _Configuration (toolbar) > Perform SSA_
   => nothing happens in the UI, no error, no any flash message
   

Notes:

• same problem occurs for SSA initiated while displaying textual summary of individual Container build
• if you try _Edit Tags_ action (between steps 2 and 3 above), the result for trying to perform SSA will be slightly different (at least something):
  
• I'm not sure if SSA for Container Builds is even implemented but I can see it in product features

[himdel]

Still looking but very likely this was supposed to end up in...

app/controllers/application_controller/ci_processing.rb
903:    when "#{pfx}_scan"                      then scanvms

[hstastna]

Yes, it looks possible but on the other hand, I am not sure if scanvms method would do the thing for Container Builds.

[himdel]

So, ContainerBuildController never had its own button method, but uses ContainersCommonMixin.

ContainersCommonMixin#button was added in https://github.com/ManageIQ/manageiq/pull/3548/ (Jul 30 2015) and hasn't called process_vm_buttons since then.

The toolbar button was added in https://github.com/ManageIQ/manageiq/pull/6084 (Jan 2016), so this never worked.

Meaning this is probably not meant to end up in scanvms after all :).

But, looking at ContainersCommonMixin, there's an explicit container_image_scan logic.

So, I think most likely the toolbar was just copied from images but never implemented. The existing logic for images looks generic enough, but relies on ContainerImage#scan, and we have no corresponding ContainerBuild#scan.

Cc @agrare - is scanning container builds supposed to be a thing? Is there a backend method we could use for it? (The alternative being we just remove the toolbar buttons from container builds.)

[agrare]

@himdel ContainerImage (https://github.com/ManageIQ/manageiq/blob/master/app/models/container_image.rb#L4) includes the ScanningMixin (https://github.com/ManageIQ/manageiq/blob/master/app/models/mixins/scanning_mixin.rb) so it is the same interface as the rest of the smartstate scans AFAIK

The actual scan job is completely different, but that's only after the job has been started.

[himdel]

@agrare ContainerImage does, but that works. I was asking about ContainerBuild...

[agrare]

Ah, I don't think container builds ever had scanning cc @cben

[hstastna]

@himdel @agrare @cben Any update about this issue? Should we remove the button for SSA from the UI regarding Container Builds? Thanks in advance :sparkles:

[himdel]

Yup, let's remove the toolbar button :+1:

[cben]

I never heard of scanning a build either. It doesn't make sense. Remove it :+1:

(A successful build generates a new image, that could be scanned of course. But I wouldn't expect to do it from the build page.)

[hstastna]

@miq-bot assign @hstastna

[hstastna]

The button will be removed by https://github.com/ManageIQ/manageiq-ui-classic/pull/6571.