Lila: Dates always get rounded down

Created on 3 Aug 2018  路  4Comments  路  Source: ornicar/lila

Yesterday, the titled arena already said "in 1 day", when it was actually 1 day and 22-ish hours. We shouldn't round the dates down in such cases.

good first issue no scala
Source
picture thomas-daniels
👍2

Most helpful comment

timeago is 36 times smaller (1.4KB vs 51KB)

picture ornicar on 11 Aug 2018
😄3

All 4 comments

probably we should switch from days to hours at 72hrs or so

isaacl picture isaacl on 6 Aug 2018
👍1

https://github.com/ornicar/lila/blob/master/ui/site/src/timeago.js

ornicar picture ornicar on 8 Aug 2018

How about replacing timeago with momentjs or Luxon ?
http://momentjs.com/docs/#/durations/
https://github.com/moment/moment

silverbackgorilla picture silverbackgorilla on 11 Aug 2018
👎1

timeago is 36 times smaller (1.4KB vs 51KB)

ornicar picture ornicar on 11 Aug 2018
😄3
Was this page helpful?
0 / 5 - 0 ratings

Related issues

AdmiralA picture AdmiralA  路  3Comments
nikolatzotchev picture nikolatzotchev  路  3Comments
kostasvl-github picture kostasvl-github  路  4Comments
arex1337 picture arex1337  路  4Comments
Cristian-A picture Cristian-A  路  3Comments