The main reason I think this would be useful is because a lot of icon packs don't apply the icons to certain applications unless the name is exactly the same.
For example, with the browser Lightning, only the generic Play Store version gets the icon changed and not the Lightning+/F-Droid version.
Other launchers such as Nova have this option to manually change the icon but I've noticed that KISS does not, even though it's superior in every other conceivable way.
Hopefully I'm not the only one that would be interested in this and it will be implemented in the future.
CCBMhf
All 51 comments
The only issue I see with this is the interface required to make this possible.
If anyone is interested in implementing the UI than I will make the rest.
TBog
on 31 Jan 2018
keywords: custom app icons
Neamar
on 23 Mar 2020
KISS Absolutely needs this.
HunterArmstrong
on 1 May 2020
@HunterArmstrong please test my PR #1464, I need feedback.
TBog
on 1 May 2020
@TBog I totally forgot how to test that bit out. You may need to guide me through it.
HunterArmstrong
on 1 May 2020
@HunterArmstrong from CircleCi you can download the artifact, here is the link I got https://2669-6047468-gh.circle-artifacts.com/0/debug-apk/app-debug.apk
TBog
on 1 May 2020
@TBog Okay.
This is already very functional.
This it great
Thank you.
HunterArmstrong
on 2 May 2020
@TBog
I also realize this was from mainly the free version. Not the pro. Is that right?
HunterArmstrong
on 2 May 2020
@TBog
I also realize this was from mainly the free version. Not the pro. Is that right?
Not sure what you want to find out by asking that.
I used the free version of the IconPack to test my changes.
TBog
on 2 May 2020
@TBog Well. There were some things that I could not use from the pro version of verticons.
Is there a way you can test that out as well? I'm more than happy to help pay for it if that's all you need.
HunterArmstrong
on 2 May 2020
@TBog The one you tested doesn't seem to work for the pro version. Is there a way the debugged version could work for any icon pack?
HunterArmstrong
on 5 May 2020
Is there a way the debugged version could work for any icon pack?
Can you please be more specific? What seems to be the issue? Can you post the logcat and a screen shot?
TBog
on 6 May 2020
@TBog I'm saying that the .apk file you linked doesn't work for the pro version of the verticons icon pack. That is the one that I am currently using. I asked that because I thought it was just a fix that would work for other icon packs. Not just the free version of the verticons icon pack.
HunterArmstrong
on 9 May 2020
It works for any icon pack, I tested 3 random ones from Playstore and a patched version of your paid one. All work imho. Please post what issue you are having preferably with screenshots.
TBog
on 9 May 2020
@TBog okay. Thanks.
HunterArmstrong
on 9 May 2020
@TBog is there a version that is up to date with the recent version of KISS?
Edit: I was talking about the apk.
HunterArmstrong
on 11 May 2020
Yes, look at the PR, you should be able to find the apk as an artifact of CircleCi
TBog
on 11 May 2020
@TBog Okay thx
HunterArmstrong
on 11 May 2020
@TBog I just used the link again. I cant see one of the new features you have involving hiding subicons in KISS.
HunterArmstrong
on 11 May 2020
@TBog I just used the link again. I cant see one of the new features you have involving hiding subicons in KISS.
Same link, same apk.
If you want a certain feature you should find the artifact generated by CircleCi for it
TBog
on 11 May 2020
@TBog where can I find Circle CI?
HunterArmstrong
on 11 May 2020
@TBog where can I find Circle CI?
https://app.circleci.com/pipelines/github/Neamar/KISS
@HunterArmstrong follow these steps
From a commit, select the CircleCi build
Select Artifact
TBog
on 11 May 2020
@TBog how do I download that certain feature as an apk though? Im really sorry, btw. This is becoming very confusing.
HunterArmstrong
on 11 May 2020
@TBog was there ever a reason why you didn't integrate the debugged version into the KISS beta version? I'm just wondering because I feel it would be a lot easier.
HunterArmstrong
on 11 May 2020
@TBog was there ever a reason why you didn't integrate the debugged version into the KISS beta version? I'm just wondering because I feel it would be a lot easier.
I don't think you understand how git or github works.
For each new feature we make a branch and a PullRequest to be merged to master. After a PR has been submitted the continuous integration (in our case CircleCi) builds the app to check if it compiles and passes the tests, by doing this we get some artifacts, one of these is the debug apk
The beta version is built from the master branch, after we merge the branches and @Neamar decides it is stable. It is not a debug apk.
Right now we have multiple PR that are waiting to be merged to master and so you can't get an apk from the artifacts that contains all of the proposed features.
You could merge the branches on your fork to test them yourself. That's the beauty of open source.
TBog
on 11 May 2020
@TBog Okay. You're right. I didn't understand. I'm happy you explained the entire thing to me.
HunterArmstrong
on 11 May 2020
@HunterArmstrong please test my PR #1464, I need feedback.
@TBog
After testing it out, I think it functions well enough to be in another update.
An FAQ article may need to be made in order for no one to get confused or worried. But, overall I think its functional.
Also, sorry I was confused about the test version and the beta the entire time. Quarantine changes people in their mental strength sometimes.
HunterArmstrong
on 11 May 2020
@TBog Is this artifact being tested to see if it is functional enough for a new update or was this something random you found and were able to just send me a link to? Because I think this could be functional enough to be in a future update.
HunterArmstrong
on 13 May 2020
Latest artifact for PR #1464 can be found here. I merged in master and PR #1434 but it's not final until the PR is merged into master by @Neamar
TBog
on 13 May 2020
Latest artifact for PR #1464 can be found here. I merged in master and PR #1434 but it's not final until the PR is merged into master by @Neamar
@TBog You are a godsend! 馃檹馃檶馃徎馃檶馃徎 Thank you!
HunterArmstrong
on 13 May 2020
@TBog So, after about a days work of testing the new debugged version, I kind of discovered that the shortcuts kind of want to crop portions of their icon out to blend in with my icon pack. Should that be normal? I think that may be another thing that needs to be tweaked.
Either way. I really liked that added feature. Thank you so much!!馃馃
Edit: I also can't really give screenshots at the time because I have a new phone and reinstalling the app may cause itself to shut off half the time
HunterArmstrong
on 14 May 2020
I merged in master and PR #1434 but it's not final until the PR is merged into master by @Neamar
@TBog Was it made final yet by @Neamar ? Because I found a couple issues with the shortcuts in the artifact.
HunterArmstrong
on 15 May 2020
Please post the issues in the comments of the PR with pictures so I can understand better
TBog
on 15 May 2020
@TBog I really can't. I got a new phone not to long ago and it wouldn't let me use the debugged version without it flipping out.
HunterArmstrong
on 15 May 2020
Because I found a couple issues with the shortcuts in the artifact.
How did you find them? Please post photos of the issue as a comment to the PR
TBog
on 15 May 2020
How did you find them? Please post photos of the issue as a comment to the PR
@TBog I had looked at the shortcuts with my icon pack installed. They were cropped to be shaped like the icons I used. Then I got a new phone. I have no screenshots.
HunterArmstrong
on 15 May 2020
@TBog I can't get you a new screenshot of the shortcuts because the debug version won't allow me to go into the settings and change the icon pack
HunterArmstrong
on 15 May 2020
Because I found a couple issues with the shortcuts in the artifact.
How did you find them? Please post photos of the issue as a comment to the PR
@TBog Found the screenshot you were wondering about.
So, the problem I was trying to inform you about was that the icons for the shortcuts labeled castbox wanted to go through this cookie cutter like change and cut itself out to look like the app icon on the top.
That was what was bothering me for a couple days...
HunterArmstrong
on 18 May 2020
@TBog
Hey, is the icon change feature going to be in a new update yet? I'm just wondering because I noticed how there may be a couple kinks that need to be worked out and I just want to stay updated and involved. 馃槂馃槂
HunterArmstrong
on 25 May 2020
It's on hold while I deep-check the adaptive icons, and will then be reviewed too :)
Neamar
on 25 May 2020
@Neamar Well, I'm just wondering because I know it could be done. If there's anything that I can do to help out let me know. Because I want this to be just as successful and functional as you do. 馃槂馃榿
HunterArmstrong
on 25 May 2020
It's on hold while I deep-check the adaptive icons, and will then be reviewed too :)
@Neamar I'm just wondering. How long is it going to take to review this type of enhancement? And is there a way to make the next artifact easy to test out on a Samsung Galaxy S20+? Because I had issues with the last artifact when it came to opening the KISS Settings and I don't really know if it was the phone that I'm using right now.
HunterArmstrong
on 25 May 2020
When you have an issue, please send the logcat, screenshot and detailed steps to reproduce the problem so we can have a look at what went wrong, can't help otherwise.
TBog
on 25 May 2020
Okay. I had two issues with the most current artifact
As of right now I cant open the KISS settings. I believe it may be because of the version of phone that I have right now. (I had a Samsung Galaxy S20+. Pretty new)
The other issue that I had was that the shortcuts that I add to my homescreen would adapt to be scaped like the icon pack I used. Luckily I had taken a screenshot of this issue when I had my old phone.
Now, One question. Whats a logcat?
HunterArmstrong
on 25 May 2020
@HunterArmstrong read this https://www.xda-developers.com/guide-sending-a-logcat-to-help-debug-your-favorite-app/
TBog
on 25 May 2020
Okay. I had two issues with the most current artifact
As of right now I cant open the KISS settings. I believe it may be because of the version of phone that I have right now. (I had a Samsung Galaxy S20+. Pretty new)
The other issue that I had was that the shortcuts that I add to my homescreen would adapt to be scaped like the icon pack I used. Luckily I had taken a screenshot of this issue when I had my old phone.
Now, One question. Whats a logcat?
@TBog @Neamar
Okay. As I somehow figured out my first issue, I managed to take another screenshot to further show you what I mean.
The shortcuts i make adapt immediately.
And I am discomforted by it.
Everything else seems to work well. I can get rid of the subicon if I wanted.
But, that is where I am.
I can't get a logcat right now because I can't pull things up as fast right now.
But, I hope this is enough to further development.
HunterArmstrong
on 25 May 2020
@TBog @Neamar
Okay. So, for the first issue I managed to just toy with it and here's what I found
After initial launch, all the favorites icons were default system icons.
Once I went to the menu and hit KISS Settings, the debugged version crashed on me and took me straight to the home screen.
After launch 2 I notice that the favorites icons were missing and I regained the ability to hit KISS Settings without the debugged app crashing.
After hitting KISS Settings. I selected the icon pack i wanted under user interface and then hit Reset KISS under advanced settings.
And everything was how it should have been.
This should have been so much easier but I'm glad I was able to share that.
HunterArmstrong
on 25 May 2020
@Neamar Did the message I sent to this thread help out with the tweaks or is there something else I need to do?
HunterArmstrong
on 29 May 2020
I merged the underlying PR today, so I'll move on to this one soon. I think we're good for now ;)
Neamar
on 29 May 2020
@Neamar Okay. Hopefully no issues.馃馃徎馃馃徎
HunterArmstrong
on 30 May 2020
@TBog @Neamar, any update on this? Looks like you were making some great progress in #1464 several months ago.
New version on F-Droid this month does not appear to have this feature yet.
Neurognostic
on 5 Oct 2020
Related issues
zayuim
路
8Comments
cfytrok
路
7Comments
Wilker-a
路
7Comments
HunterArmstrong
路
8Comments
Larnicone
路
6Comments
Most helpful comment
The only issue I see with this is the interface required to make this possible.
If anyone is interested in implementing the UI than I will make the rest.