Jetpack: Instant Search: Non-English taxonomy filter is encoded

Created on 22 Oct 2019  Â·  5Comments  Â·  Source: Automattic/jetpack

Steps to reproduce the issue

  1. Follow instructions in https://github.com/Automattic/jetpack/pull/13761 to get search running
  2. Configure a taxonomy filter for language on wordpress.tv
  3. Load up the filters and you will see:

Screen Shot 2019-10-22 at 2 06 12 PM

Instant Search Search [Type] Bug

Most helpful comment

I think the correct approach would be to correct this in the API.

In an ideal world, the above screenshot might look like the following:

  • english should be English, or English (American)
  • spanishespanol should be Spanish (Español)
  • germandeutsch should be German (Deutsch)
  • frenchfrancais should be French (Français)
  • japanese%e6%97%a5%e6%9c%ac%e8%aa%9e should be Japanese (日本語)

Screen Shot 2019-10-28 at 1 04 26 PM

All 5 comments

Is the plan to fix this encoding in the endpoint, or do we want to do it on the client side?

I was thinking in the client, but I really haven't looked at exactly what is coming from the API and ES.

I think the correct approach would be to correct this in the API.

In an ideal world, the above screenshot might look like the following:

  • english should be English, or English (American)
  • spanishespanol should be Spanish (Español)
  • germandeutsch should be German (Deutsch)
  • frenchfrancais should be French (Français)
  • japanese%e6%97%a5%e6%9c%ac%e8%aa%9e should be Japanese (日本語)

Screen Shot 2019-10-28 at 1 04 26 PM

Fixed in #14437.

Was this page helpful?
0 / 5 - 0 ratings