Jetpack: Markdown: Enabling does nothing on latest master

Created on 18 Feb 2017  路  3Comments  路  Source: Automattic/jetpack

To repro:

  1. Run latest master of Jetpack.
  2. With Markdown module off, enable it.
  3. Add a new post/page, enter some markdown.
  4. Publish it.

What I expected: markdown to be changed to HTML.

What happened: markdown comes out raw. Screenshot:

screen shot 2017-02-18 at 10 05 00 am

I think this is because the new setting under Settings > Writing does not automatically get turned on:

screen shot 2017-02-18 at 10 05 46 am

Probably related to https://github.com/Automattic/jetpack/pull/6406 cc @eliorivero

Markdown [Pri] BLOCKER [Type] Bug

Most helpful comment

@jeherve that commit referenced by @Stoyan0v is only for the new settings UI.

I'll try to devise something for the current UI.

All 3 comments

It seems that there are two PRs for Markdown module.
The first one is #6406 and it adds new endpoint and removes the code that enables the module.

The second one #6396 is similar to the first one, but it has additional commit (8c1ba3dc9d27dffc184e786f8f7c45d3ed7ccbd3) which contains the code for enabling the module ( this code is missing in master branch right now ).

The issue is that the second PR is merged in feature/settings-overhaul branch not in master, while the first one is merged in master. So I think that if the feature/settings-overhaul branch will be merged in master before 4.7 release, the module will work as expected.

cc @jeherve @eliorivero

@eliorivero Do you think we should bring that commit over to master?

@jeherve that commit referenced by @Stoyan0v is only for the new settings UI.

I'll try to devise something for the current UI.

Was this page helpful?
0 / 5 - 0 ratings