Image-sequencer: Overlay module not working initially

[blurry-x-face]

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?

I loaded overlay module

What did you expect to see that you didn't?

I expected to see the output image

Please show us where to look

https://beta.sequencer.publiclab.org/examples/#steps=overlay{}

What's your PublicLab.org username?

rishabhshukla1999

This can help us diagnose the issue:

Browser, version, and operating system

Chrome Version 79.0.3945.79 (Official Build) (64-bit) on Ubuntu 18 LTS

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!

---

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

[blurry-x-face]

@jywarren Can I work on this?

[ataata107]

You need to have atleast two images for this module to work

[blurry-x-face]

Yes it should prevent this from happening, maybe show a toast notification instead of just loading?

[ataata107]

Yes that should be there

[blurry-x-face]

Right now many of the modules have this problem(ex: blend module) you can put any number in the input I was thinking maybe it should show a visible error? This was just an idea If the moderators agree I can work on it.

[root00198]

I think you should add a default image.

[harshkhandeparkar]

I think a better way would be to change the default offset to -1 instead of -2. There will always be a step before the current step. That should fix everything.

[harshkhandeparkar]

What are your thoughts?

[root00198]

Yeah That looks like a great idea...

[jywarren]

Hm, just noting that I believe it's supposed to take image -2 and overlay it on image -1, does that make sense?

[harshkhandeparkar]

Good point. I think it would be even better if we use -1 as a default
only if -2 doesn't exists. We could use an if condition here.

On Sat, 11 Jan, 2020, 11:54 PM Jeffrey Warren, [e-mail]
wrote:

Hm, just noting that I believe it's supposed to take image -2 and overlay
it on image -1, does that make sense?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/1430?email_source=notifications&email_token=AIJI5HYZ7PNCO7PJX4HNVD3Q5IFFPA5CNFSM4KDKMYNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWIAGA#issuecomment-573341720,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIJI5H7OZ2U3JRV5RO23JG3Q5IFFPANCNFSM4KDKMYNA
.

[blurry-x-face]

What are your thoughts?

I was thinking of adding these inputs as ranged inputs where we could maybe display the name of the step as input, what do you think?

[harshkhandeparkar]

https://github.com/publiclab/image-sequencer/pull/1459#pullrequestreview-341587142