Image-sequencer: this.stringToSteps is not a function in ReplaceImage

Created on 19 Apr 2019  路  5Comments  路  Source: publiclab/image-sequencer

Hi @VibhorCodecianGupta -- thank you SO MUCH for #787 -- i'm really excited to put it to use.

I noticed an error in replaceImage --

Uncaught TypeError: this.stringToSteps is not a function

It seems to be related to this scope in this segment of code:

https://github.com/publiclab/image-sequencer/blob/e7fbada71efda1f4c5912037ac90f3b86b9e4670/src/ReplaceImage.js#L43-L54

You can reproduce it by clicking any button on this page:

https://publiclab.github.io/leaflet-tile-filter/

Would you have a little time to check this out? Thank you so much!

bug

Most helpful comment

Ah, yes. Uh, i think we can initialize a new sequencer with s = new ImageSequencer(); s.replaceImage(...) in the console, at least for testing. Perhaps we should create a test for it as well. Thank you!

All 5 comments

On it. A little help, how to reproduce this on Image Sequencer? This runs in the browser context, right? I'll solve this and #1029 in the same PR

Ah, yes. Uh, i think we can initialize a new sequencer with s = new ImageSequencer(); s.replaceImage(...) in the console, at least for testing. Perhaps we should create a test for it as well. Thank you!

I'll get it working, then. See if we can create a test case here too.

@jywarren I think I managed to get this working, however, I want to test it out once. The browser script should run, but is not for me, for some reason. The image having that CSS selector remains unchanged with undefined console output. Were you able to reproduce this in the console?
I don't want to push the code without proofing it first, thanks

Hmm, so, can you show the solution you've got in a PR? I can try testing it, or if you want to download https://publiclab.github.io/leaflet-tile-filter/ and point it at your modified version, to confirm, that'd work too. Thanks!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

harshkhandeparkar picture harshkhandeparkar  路  5Comments

keshav234156 picture keshav234156  路  4Comments

harshkhandeparkar picture harshkhandeparkar  路  4Comments

harshkhandeparkar picture harshkhandeparkar  路  4Comments

jywarren picture jywarren  路  5Comments