Image-sequencer: Error: Cannot read property 'options' of undefined

[jywarren]

I'm seeing this on the latest main branch, when clicking a quick-add module: https://sequencer.publiclab.org/examples/

image-sequencer.js:68615 Uncaught TypeError: Cannot read property 'options' of undefined
    at Object.modulesInfo (image-sequencer.js:68615)
    at Object.selectNewStepUi (image-sequencer-ui.js:294)
    at HTMLDivElement.<anonymous> (image-sequencer-ui.js:83)
    at HTMLDivElement.dispatch (jquery.min.js:2)
    at HTMLDivElement.y.handle (jquery.min.js:2)

[jywarren]

I think we could do a few things here;

1. let's move all /examples/lib/ into /src/ui/
2. let's make a test for clicking the previews and confirming a step is added, in this test
3. let's give the preview buttons unique CSS classes like preview-step preview-step-resize so we can more easily write the test.

[jywarren]

But I can't find where the previews onClick events are connected up... that's what I want to write a test for and fix...

[jywarren]

That's right. I'll try uploading one later today! @Harshkhandeparkar do you
see it running normally?

On Tue, Mar 19, 2019, 1:11 AM Vibhor Gupta [e-mail] wrote:

@jywarren https://github.com/jywarren the quick-add modules are the
modules on the widget that we can add on a single click, right? I can't
seem to reproduce the issue. Is there a screenshot?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/888#issuecomment-474200729,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ2uERbgh9qL5VMavTCH-gBWBNeAVks5vYHFzgaJpZM4b7J0z
.

[VibhorCodecianGupta]

I was able to reproduce the issue. Tricky, this one. Trying to backtrack.

[jywarren]

Thanks Vibhor!!!

On Tue, Mar 19, 2019, 8:38 AM Vibhor Gupta [e-mail] wrote:

I was able to reproduce the issue. Tricky, this one. Trying to backtrack.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/888#issuecomment-474344151,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ91kO-8GxT9zKsKTBtMixrog7M89ks5vYNofgaJpZM4b7J0z
.

[jywarren]

Publishing 3.0.1 now! @Divy123 @HarshKhandeparkar @publiclab/is-reviewers @VibhorCodecianGupta @tech4GT - thank you!!!

[Divy123]

Feeling great to be a part of this. :heart:
Thanks a lot @jywarren @tech4GT @HarshKhandeparkar for helping out always .