Image-sequencer: Use of socket.io for two people to work on same image simultaneously(Long Term)

[Divy123]

This feature involves two people to edit the same image by using web sockets which can be a good use case for collaborative image-sequencing.

[Divy123]

@jywarren if you like the idea I would like to work on this.

[VibhorCodecianGupta]

I don't fully understand the use case of this.
The sequencer provides the ability to save the chained sequences already. If for example, user A wants to edit an image a certain way, they can create a sequence and export it to user B who can then edit the same by chaining more modules. Would there be a need to create sequences via web sockets?

[Divy123]

So the point is suppose there are two users who want to create a sequence of image by applying different effects simultaneously working for some project(lets say).
Won't that be better that we provide that sharing included in our image-sequencer itself which can save the time of both else they would open some external sharing medium and do all this stuff.
Suppose the users have to do this very frequently which can actually waste a lot of time using external source of sharing.
So by this the things can be made quite handy.

[VibhorCodecianGupta]

Hmm. @jywarren thoughts?
I still feel using a socket for this sake might be overkill. Something, like allowing sending your created and saved sequences over file-sharing networks or emails etc, would be cooler. The file-sharing strategy is pretty straight forward and I'd love to implement it. Let's brainstorm on this and see what comes up

[Divy123]

Sure let's see .
Also I would be happy with your collaboration on this.
Thanks😄

[harshkhandeparkar]

@Divy123 @VibhorCodecianGupta maybe implementing sockets directly into image sequencer might be overkill. Instead providing a plugin of some sort can be better. This can also open future possibilities for user made plugins.

Another option would be to provide a wrapper which can take image sequencer core library and core ui as arguments and return a supercharged package just like a react HOC. Thoughts?

[jywarren]

This is really interesting... I actually want to suggest that we consider
something like this for
https://github.com/publiclab/Leaflet.DistortableImage

Or for https://github.com/publiclab/mapknitter which uses the above lib.
Any interest in something like that?

On Sun, Jan 27, 2019, 2:25 AM Harsh Khandeparkar <[email protected]
wrote:

@Divy123 https://github.com/Divy123 @VibhorCodecianGupta
https://github.com/VibhorCodecianGupta maybe implementing sockets
directly into image sequencer might be overkill. Instead providing a plugin
of some sort can be better. This can also open future possibilities for
user made plugins.

Another option would be to provide a wrapper which can take image
sequencer core library and core ui as arguments and return a supercharged
package just like a react HOC. Thoughts?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/718#issuecomment-457890338,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJwfLEN1FOfOgXCOMAdahdT_hSMp8ks5vHTg4gaJpZM4aUTi7
.

[harshkhandeparkar]

@jywarren can you please provide some info about leaflet.distortableimage and mapknitter? Also what part of those libraries are similar to this issue?

[jywarren]

Ah just noting that it's a very strong use case for sockets because there's
strong interest in simultaneous editing there. Whereas here that would be
interesting but perhaps also not a core goal of the library. Thanks!!

On Sun, Jan 27, 2019, 6:38 PM Harsh Khandeparkar <[email protected]
wrote:

@jywarren https://github.com/jywarren can you please provide some info
about leaflet.distortableimage and mapknitter? Also what part of those
libraries are similar to this issue?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/718#issuecomment-457956690,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ0mjNiFjbg2HY3b9utpIiVgyeVi4ks5vHhxHgaJpZM4aUTi7
.

[Divy123]

Thanks @jywarren for your suggestion.
I would be really happy to contribute towards the same
Could you please guide me how should I proceed?
Using websockets to implement this feature is quite awesome.

[Divy123]

@jywarren can you please help me out with this?

[jywarren]

I'll try later but I'm about to board a flight! Sorry!!! 🛫

On Jan 29, 2019 3:24 PM, "Slytherin" [e-mail] wrote:

@jywarren https://github.com/jywarren can you please help me out with
this?

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/718#issuecomment-458651079,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ-YEvjiFwgHIe0Sbb2iw2exEaBL-ks5vIJHNgaJpZM4aUTi7
.

[Divy123]

No problem @jywarren . Happy journey :smile:

[jywarren]

Hi! Please check out these ideas I've written out at greater length!

https://publiclab.org/wiki/gsoc-ideas#MapKnitter+Synchronous+Editing

[jywarren]

Related to https://github.com/publiclab/mapknitter/issues/300

[harshithpabbati]

Does anyone working on it??? I am really interested in taking it to work. Can I ??

[harshkhandeparkar]

Harshith this is an advanced issue. Also please not that this is a long term one which means that it is not our main priority as of now. If you are ok with it then you can start brainstorming rather than opening a straight PR. Thanks!

[harshithpabbati]

@HarshKhandeparkar yeah sure. I made a similar app where we can chat with other one who comes to the same room.So i was really interested in making it out .
Thanks

[harshkhandeparkar]

Go ahead

On Thu 21 Feb, 2019, 8:28 PM Harshith pabbati <[email protected]
wrote:

@HarshKhandeparkar https://github.com/HarshKhandeparkar yeah sure. I
made a similar app where we can chat with other one who comes to the same
room.So i was really interested in making it out .
Thanks

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/718#issuecomment-466030619,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AhKOn4tG-O4H7_SjFlJD6BcwmyVLjlv3ks5vPrP8gaJpZM4aUTi7
.

[harshithpabbati]

shall i work on it or else wait for sometime??

[harshkhandeparkar]

@jywarren @publiclab/is-reviewers what are your thoughts?

[Divy123]

This issue turned out to be more helpful in case of https://github.com/publiclab/Leaflet.DistortableImage .
So its not of much consideration here .
You may give it a try there.
Thanks.

[jywarren]

Hi - I think this is a bit complex of a use case to think about, in part because it could require a server to track changes. I suggested that people interested in sockets work might look at another Public Lab project where we're more likely to tackle this sooner, as it's a higher priority.

I'd recommend looking at the "simultaneous multi-user UI, like Google docs" section of https://github.com/publiclab/mapknitter/issues/300 if you're interested.

I think we could continue brainstorming here, but we'd have to really map out how it'd work and what'd be required and since we're already going to be doing that sooner for mapknitter, I thought that's a place we could prototype this idea a bit. Thanks!

[harshithpabbati]

I made an web app using socket.io. I will host it in something like heroku and send you the link.See it and say what changes should i make in it .what do you say??

[harshithpabbati]

Checkout this link https://afternoon-lake-15004.herokuapp.com/
Thanks

[harshithpabbati]

@publiclab/is-reviewers what do you say???

[jywarren]

Hi, all, so, after discussing and such, I think I'll close this and we can focus on use of sockets in other projects. Thank you!