Hugothemes: Theme submission: Hugo-profile

[gurusabarishh]

Theme submission

Link to my theme repository: https://github.com/gurusabarish/hugo-profile

I made sure that...

• [x] the repository contains a good README.md describing my theme
• [x] an open source license has been added to LICENSE.md
• [x] all metadata have been added to theme.toml
• [x] in case I'm using a customized demo via the exampleSite folder that
  
  
  
  • [x] https://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domains
  
  
  • [x] I tested that my theme's demo works with the content directory of gohugoio/HugoBasicExample
  
  
• [x] screenshots have been added in the images/ folder with the required dimensions

Link to my Twitter account (optional): https://twitter.com/gurusabarishh

[gurusabarishh]

@digitalcraftsman anything is wrong with theme?

[digitalcraftsman]

Hi Guru,

right now I'm short on time because I've to study for two exams. Hence the delay in the review of your submission. At the beginning of October I'll have more time to continue the review of theme submissions.

[gurusabarishh]

Thanks for your reply,
Take your time and study well for exams.

[digitalcraftsman]

Hello @gurusabarish

thank you for sharing this theme with the Hugo community. While reviewing your theme I noticed a few issues:

• please remove the hard-coded Google Analytics id in the example config file
• when submitting a theme intended for broader usage avoid hard-coded strings as done here. Not everyone is from India and uses web technologies.
• please rename the examplesite folder to exampleSite. Otherwise, it can't be found by the build script for www.themes.gohugo.io
• the included Javascript files can't be found because the directory is named static/Js instead of static/js. Please mind how you name your directories.

[gurusabarishh]

Thank you @digitalcraftsman for your review and notification.

Sorry,
I didn't notice these issues. Now, I fixed these issues.

• [x] Remove the hard-coded Google Analytics
• [x] Avoid hard-coded strings
• [x] Rename the examplesite and Js folders to exampleSite and js

[digitalcraftsman]

Thanks for applying the fixes. There are two other minor issues I've found:

• please make the links to the images here and here relative to the stylesheet by prefixing the path with ... The images are always assumed to be at www.example.com/images/file.name. This doesn't work anymore if themes are hosted in a subdirectory as in www.example.com/blog/images/file.name. This is the case for theme demos.
• I suggest to make this button text also customizable. You may use a better default because the button doesn't link to a blog (post) right now and users of your theme might link to other locations than blogs.

[gurusabarishh]

Thanks @digitalcraftsman for the suggestion. Now I fixed these issues.

please make the links to the images here and here relative to the stylesheet by prefixing the path with ... The images are always assumed to be at www.example.com/images/file.name. This doesn't work anymore if themes are hosted in a subdirectory as in www.example.com/blog/images/file.name. This is the case for theme demos.

Now I fixed.

I suggest to make this button text also customizable. You may use a better default because the button doesn't link to a blog (post) right now and users of your theme might link to other locations than blogs.

As your suggestion, I made the buttons also customizable.

[digitalcraftsman]

Your theme is already live on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.

[gurusabarishh]

Thanks @digitalcraftsman for accepting the theme