Hugothemes: Theme submission: Vibrant-Shadows

[SanmayJoshi]

Theme submission

Link to my theme repository: https://github.com/Softorage/HugoTheme-VibrantShadows

I made sure that...

• [x] the repository contains a good README.md describing my theme
• [x] an open source license has been added to LICENSE.md
• [x] all metadata have been added to theme.toml
• [x] screenshots have been added in the images/ folder with the required dimensions
• [x] in case I'm using a customized demo via the exampleSite folder that
  
  
  
  • [x] https://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domains
  
  
  • [x] I tested that my theme's demo works with the content directory of gohugoio/HugoBasicExample
  
  
• [x] I tested my theme against the gohugoio/HugoBasicExample
  
  
  
  • [x] I've checked the developer tools' console in my browser for error messages
  
  
• [x] in case my theme is using Hugo Pipes features like toCSS and PostCSS that I have committed the /resources directory with all generated assets, for my theme to work in the basic version of Hugo
  
  Link to my Twitter account (optional): https://twitter.com/Softorage/

  Feel free to ask questions. :smile:

[SanmayJoshi]

@digitalcraftsman is the theme missing anything?

[digitalcraftsman]

Hello @SanmayJoshi,

thank you for sharing this theme with the Hugo community. Excuse the delay in the review process. I had to prepare exams at the end of November and a backlog of other theme submissions.

When building your theme I get the following error message:

Error: Error building site: TOCSS: failed to transform "assets/css/main.scss" (text/x-scss): resource "scss/sass/main.scss_ac3cc187e91d95c58edb8799e6a041e7" not found in file cache

Please make sure to commit the generated stylesheets as well when updating the source files.

[SanmayJoshi]

thank you for sharing this theme with the Hugo community

It's my pleasure!

Excuse the delay in the review process. I had to prepare exams at the end of November and a backlog of other theme submissions.

No worries. I wish you the best for exams and results!

When building your theme I get the following error message:

Error: Error building site: TOCSS: failed to transform "assets/css/main.scss" (text/x-scss): resource "scss/sass/main.scss_ac3cc187e91d95c58edb8799e6a041e7" not found in file cache

Please make sure to commit the generated stylesheets as well when updating the source files.

I apologize for any inconvenience I may have caused. I looked at the issue and found out that there was an error while reading Hugo's environment in the code. (I think 😅) I have rectified the code, and it should run smooth now. Please feel free to let me know if any problems arise.

Thanks for your friendly assistance.

[digitalcraftsman]

Thank you for applying the fixes. Your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.

While looking at your changes I noticed that the following assets can't be found:

GET http://localhost:1313/theme/HugoTheme-VibrantShadows/assets/favicon/apple-touch-icon.png
[HTTP/1.1 404 Not Found 
GET http://localhost:1313/theme/HugoTheme-VibrantShadows/assets/favicon/favicon-32x32.png
[HTTP/1.1 404 Not Found 0ms]

As this are non-blocking issues for the review I've left them for a future theme update.

[SanmayJoshi]

Your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.

🤩 Thanks a lot!

While looking at your changes I noticed that the following assets can't be found:

GET http://localhost:1313/theme/HugoTheme-VibrantShadows/assets/favicon/apple-touch-icon.png
[HTTP/1.1 404 Not Found
GET http://localhost:1313/theme/HugoTheme-VibrantShadows/assets/favicon/favicon-32x32.png
[HTTP/1.1 404 Not Found 0ms]

As this are non-blocking issues for the review I've left them for a future theme update.

Thanks for pointing out! Just fixed them, in fact upgraded the theme's favicon functionality a bit!