Hello @kishaningithub
thank you for sharing this theme with the Hugo community.
While testing your theme with the build script for the Hugo theme site I noticed that the homepage always redicrects to /products. This causes problems if the website is hosted inside a subdirectory, e.g. www.themes.gohugo.io/theme/some-theme. In this case users who want to have a look at the theme demo will always be redirected to the non-existing page at www.themes.gohugo.io/products.
You can fix that by using the absURL, relURL template functions as follows:
{{ "/products" | absURL }}
@digitalcraftsman Done! Can you check now ?
Ref - The commit
I forgot that a url with a leading slash will still be interpreted relative to the root directory, not base-url. {{ "products" | absURL }} (notice the missing leading slash) fixes this. Sorry for that.
Otherwise your theme works fine and is ready to be added.
@digitalcraftsman Done! And thanks for your code reviews! :-)
Ref - The commit
Your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.
Most helpful comment
Your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.