I think I've got everything set up properly per the guide for my first Hugo theme. It'd be really great if you could add it to the theme directory!
@AngeloStavrow thank you so much for sharing your theme with the Hugo community!
I 鉂わ笍 your theme and everything works fine.
However there is one minor detail that needs to be addressed.
I noticed that you are serving Fira Code from rawgit:
@import url(https://cdn.rawgit.com/AngeloStavrow/FiraCode/1.205/distr/fira_code.css);
However as per RawGit's README it is not a good idea to use it for serving files in production.
Can you have a look into it and let me know?
Thanks!
@digitalcraftsman This is a very special Hugo theme because it has IndieWeb features. Also it is Privacy minded. There are zero third party requests and zero JS.
CC/ @kaushalmodi I think you may want to have a look into this theme.
Thanks for the kind words, @onedrawingperday!
Bundling the font is something that I meant to do but got away from me with the release, I'm sorry for the inconvenience. I've opened issue 17 to fix this and expect to push a fix within the next 36 hours.
It's good to see the word of IndieWeb spreading more day by day.
Also it is Privacy minded. There are zero third party requests and zero JS.
That's awesome too!
@AngeloStavrow I haven't looked at your theme in detail, but I'll do so in the coming week.
@kaushalmodi I'm looking forward to your thoughts on how it can be improved!
@onedrawingperday v1.0.1 now bundles Fira Code in the theme, rather than importing it from rawgit. Thanks again for catching that!
@digitalcraftsman
This theme is ready to be added to the website.
Hello @AngeloStavrow,
thank you for sharing this theme with the Hugo community. I wasn't aware of the indieweb and indieauth projects. Thanks for sharing.
Your theme should be listed soon on the themes site. Furthermore, I'll promote your theme on Hugo's official Twitter account.
Thanks @digitalcraftsman! I see that for some reason, fonts aren't loading correctly on the demo site; I'll have a look at what's going on there.
Ah, I think the issue was that I was referencing the theme in the exampleSite's config.toml as ../.. instead of the theme name. This is fixed in v1.0.2 and when I build the themeSite to test it, it works as expected. 馃檪
Hey Angelo,
all themes have been updated. The changes should appear in a few minutes on the Hugo theme site. Let me know if this problem still occurs in the demo of your theme.
Hmm, there still seems to be an issue, @digitalcraftsman. All fonts and images are found their own subdirectory under /static (e.g., /static/icons or /static/fonts). I'm going to add my notes here as I try to figure this out in case it's useful for future theme contributors.
I'm looking at the requests on https://themes.gohugo.io//theme/indigo and here's what I see:
The request URL for the social icons is https://themes.gohugo.io//theme/indigo/icons/icon-name.svg
<img src="/icons/icon-name.svg /> in layouts/partials/social.html, and they show up as expected.The request URL for the fonts is https://themes.gohugo.io/fonts/font-name.woff
src: url('/fonts/font-name.woff)instatic/css/style.css`, and they're not being loaded.I thought this was working in my testing of the theme site, but it turns out that the browser was just caching fonts. :facepalm:
I'm going to continue digging in to this, but if anyone has any thoughts or hints, they're always appreciated. 馃檪
Okay, this should be solved in v1.0.3 (see related issue) of the theme. 馃帀
Most helpful comment
@AngeloStavrow thank you so much for sharing your theme with the Hugo community!
I 鉂わ笍 your theme and everything works fine.
However there is one minor detail that needs to be addressed.
I noticed that you are serving Fira Code from rawgit:
@import url(https://cdn.rawgit.com/AngeloStavrow/FiraCode/1.205/distr/fira_code.css);However as per RawGit's README it is not a good idea to use it for serving files in production.
Can you have a look into it and let me know?
Thanks!
@digitalcraftsman This is a very special Hugo theme because it has IndieWeb features. Also it is Privacy minded. There are zero third party requests and zero JS.
CC/ @kaushalmodi I think you may want to have a look into this theme.