Hugothemes: Themefisher submissions

[mehedi-sharif]

Hello Team,
We have created a new hugo theme for the hugo community .
Here is the repo https://github.com/themefisher/infinity-hugo .
Demo Link: http://demo.themefisher.com/themefisher/infinity/
Thanks

[digitalcraftsman]

Hello @mehedi-sharif,

great to hear from you again. As always you're submitting a wonderful theme :+1:

Please make sure that the thumbnail and screenshots in the images will be added. You can find more information in the README.

[mehedi-sharif]

Hello @digitalcraftsman ,
Thanks for your reply. Ok I am going to update the readme file . I have another theme in my list to submit in hugo themes .
Repo Link: https://github.com/themefisher/navigator-hugo
Demo link: http://demo.themefisher.com/themefisher/navigator .
The good news is more themes are coming from themefisher team . We have a target to release 20 themes for hugo store . Hope we get full support from you guys. Hugo is awesome .
Thanks

[digitalcraftsman]

The good news is more themes are coming from themefisher team . We have a target to release 20 themes for hugo store . Hope we get full support from you guys. Hugo is awesome.

That's awesome news. This would make you the largest theme contributor I guess. Thank you for investing in this project!<

By the way: your navigator theme has already been added.

[mehedi-sharif]

I can not see the navigator theme in the list. Can you please share the link with me. And how about the infinity theme . I have fixed the issues in infinity theme . Can you please add them too .
Thanks

[digitalcraftsman]

I can not see the navigator theme in the list. Can you please share the link with me.

Here it is: https://themes.gohugo.io/navigator-hugo/
I created the corresponding tweet as well.

I have fixed the issues in infinity theme . Can you please add them too .

Sure. I didn't saw the latest commit with the changes.

[digitalcraftsman]

The build script for the Hugo theme site expects a content folder inside the exampleSite directory. To make it trackable for Git create a dummy file inside the content folder, e.g. exampleSite/content/.gitkeep.

Otherwise your theme is ready to be added.

[mehedi-sharif]

Ok I am going to update this . I have few plans and I want to talk with you guys personally . Is that possible ?
Thanks

[digitalcraftsman]

I have few plans and I want to talk with you guys personally . Is that possible ?

The best way to communicate depends on who you mean with "guys". You can reach me on Gitter, Twitter or via e-mail under digitalcraftsman at protonmail . com. I you would like to start a conversation with more people I guess the best option is Gitter.

[mehedi-sharif]

The build script for the Hugo theme site expects a content folder inside the exampleSite directory. To make it trackable for Git create a dummy file inside the content folder, e.g. exampleSite/content/.gitkeep.
Otherwise your theme is ready to be added.

My developer told me that as infinity is a onepage template thats why those files are missing . Can you please recheck .
Thanks

[mehedi-sharif]

Hello @digitalcraftsman
We have created another template called Timer . Hope you review it and update in hugo themes .
Repo Link: https://github.com/themefisher/timer-hugo
Demo link: http://demo.themefisher.com/themefisher/timer/
Thanks

[onedrawingperday]

Hi @mehedi-sharif currently I am helping out with theme submissions.

Thank you for your ongoing contributions! 👍

Regarding the Infinity theme I have checked it again.

Please tell your developer that you really need to create a dummy file inside the content folder of the example site, e.g. exampleSite/content/.gitkeep because the Hugo Themes site build script requires a `/content/ folder for a theme's example site.

There is an open issue about making the content folder optional for one page themes (see Issue #387 ) but this has not been implemented yet.

Please make this small addition and let me know so that I can mark the Infinity theme as ready to be included on the site.

Thank you!

[onedrawingperday]

@mehedi-sharif

Regarding your Timer theme the /images/ folder is missing from the example site.

Can you please add the missing images so that I can review your theme further?

Thanks!

[digitalcraftsman]

@mehedi-sharif how are you doing? Is there anything new to share?

[mehedi-sharif]

Hello @digitalcraftsman , As my team is busy with other projects its hard for us to update the theme. Hopefully soon we will update the themes according to your requirements.
Thanks

[digitalcraftsman]

As my team is busy with other projects its hard for us to update the theme. Hopefully soon we will update the themes according to your requirements.

That's business. After the discussion went silent I was just curious about what's coming next because your themes look pretty awesome.

[mehedi-sharif]

We will update everything soon :)

[mehedi-sharif]

Hello @digitalcraftsman ,
we have changed everything according to your issues. Its time to include those themes in hugo directory .
Thanks

[digitalcraftsman]

Hello Mehedi,

your timer them has been added. As always I'll tweet about it.
A minor issue I noticed is that you're referencing Google fonts via http while other connections happen via https. My browser shows a security warning about the mix of http and https conncections. Fixing this is straightforward.

[digitalcraftsman]

@mehedi-sharif shall I keep this issue open in case you're preparing more themes for a submission?

[mehedi-sharif]

As our plan is to add more themes in hugo directory I think you should open this issue. How about our infinity template. Is there any luck for that template. We fixed what you wanted us to fix . Please have a look and add infinity in hugo directory :)

[mehedi-sharif]

@digitalcraftsman Something went wrong with this demo
https://themes.gohugo.io/theme/navigator-hugo/fr
Could you please take a look here.
Thanks

[divinerites]

@digitalcraftsman Something went wrong with this demo
https://themes.gohugo.io/theme/navigator-hugo/fr

@mehedi-sharif I do think I found the culprit (relref for pipe CSS and no /url). The theme was working by itself but not for the hugo demo folder structure.

See : https://github.com/gohugoio/hugoThemes#common-permalink-issues

I just made a commit to your original repo, and hopefully this should fix the problem with a bad css and bad logo URL.

[onedrawingperday]

@divinerites Thank you so much!

@mehedi-sharif The above PR should resolve the issue with the missing stylesheet in the Navigator Hugo Theme.

[divinerites]

mmm ... wait & see if this really solves it 😸

[onedrawingperday]

@divinerites I checked the theme with the merged PR and when I execute the Build Script, the demo of the Navigator Hugo Theme is generated again with all its assets.

The demo on the website will be updated once the repository is updated.

[divinerites]

Fantastic. Thanks a lot for your work on themes.

Le ven. 14 sept. 2018 20:33, Alexandros [e-mail] a écrit :

@divinerites https://github.com/divinerites I checked the theme with
the merged PR and when I execute the Build Script, the demo of the
Navigator Hugo Theme is generated again with all its assets.

The demo on the website will be update once the repository is updated.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gohugoio/hugoThemes/issues/381#issuecomment-421446979,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ae2DJxF84aTlay2bSEwuM4uslbLpvrFIks5ua_aIgaJpZM4VC9XE
.

[mehedi-sharif]

Hello @divinerites Thanks for your afford .
@onedrawingperday could you please check our other themes and if they are fit could you please add theme in hugo theme repository .
Thanks

[onedrawingperday]

@mehedi-sharif I have no access rights in this repository. Only @digitalcraftsman can add themes.

[digitalcraftsman]

@mehedi-sharif @divinerites your theme has been updated and appears in it's old glory again.

[divinerites]

@mehedi-sharif i couldn't find an other way to contact you. Sorry for hijacking this thread.

• Do you have plans to port your Hotel Eden theme to Hugo ? I would buy it.
• If not, according to your experience what is the effort to port it (me) ? Big ? Average ?

[mehedi-sharif]

@digitalcraftsman thanks for your afford.
@divinerites you can add me in skype (mehedi.titas) or you can email me [email protected] . If you check my repositories I have my email address everywhere. May be skype is a great place to talk rather than emails ;)
Thanks

[mehedi-sharif]

@digitalcraftsman Here is another onepage theme from themefisher.
https://github.com/themefisher/meghna-hugo .
Let me know your thoughts .
Thanks

[onedrawingperday]

Hello @mehedi-sharif

I tested your new Meghna Hugo Theme and I have noticed the following issues:

• The preloader does not disappear once the page has loaded. This is a Javascript problem (so we cannot offer feedback on this).
• The navigation top bar that appears under the Blog section of your site is broken because it is identical to what is used on the index page. For example once I am in the single page of /theme/meghna-hugo/blog/simple-post-title/ the navigation links point to <a data-scroll="" href="#about">About Us</a> instead of <a data-scroll="" href="http://localhost:1313/#about">About Us</a>

To fix this wrap the existing navigation under an .IsHome condition like so or similar:

       {{ if .IsHome }}        
<nav class="collapse navbar-collapse navbar-right" role="Navigation">
            <ul id="nav" class="nav navbar-nav navigation-menu">
                <li><a data-scroll href="#body">{{ with $.Site.Params.home }}{{ . }}{{ end }}</a></li>
                {{ range $.Site.Menus.nav }}
                <li><a data-scroll href="#{{ .URL }}">{{ .Name }}</a></li>
                {{ end }}
            </ul>
        </nav>
{{ else }}
<nav class="collapse navbar-collapse navbar-right" role="Navigation">
            <ul id="nav" class="nav navbar-nav navigation-menu">
                <li><a data-scroll href="{{ $.Site.BaseURL }}#body">{{ with $.Site.Params.home }}{{ . }}{{ end }}</a></li>
                {{ range $.Site.Menus.nav }}
                <li><a data-scroll href="{{ $.Site.BaseURL }}#{{ .URL }}">{{ .Name }}</a></li>
                {{ end }}
            </ul>
        </nav>
{{ end }}

Please do the above and let me know.

Thanks!

[mehedi-sharif]

@onedrawingperday issue has been fixed . could you please check now .
Thanks

[onedrawingperday]

Hello @mehedi-sharif

The latest commit I see in https://github.com/themefisher/meghna-hugo is f603b17 from Sep 12

I'm afraid that your developer has not pushed a fix for the above issues.

Thank you.

[mehedi-sharif]

I am sorry . They push in wrong repo . Could you please check now.

[onedrawingperday]

No problem @mehedi-sharif

I checked and everything seems OK on my end.

@digitalcraftsman The Meghna Hugo Theme by Themefisher is ready to be added to the website.

[digitalcraftsman]

Awesome theme @mehedi-sharif :+1:
If added a moment ago and tweet about it as usual.

[mehedi-sharif]

@digitalcraftsman thank you so much . More themes are coming for hugo platform .. Soon we will release them. Still now the old theme infinity (https://github.com/themefisher/infinity-hugo) is not in the store . Could you please take a look on it.
Thanks

[mehedi-sharif]

Here is a miss link in this page under homepage button https://themes.gohugo.io/timer-hugo/. it goes to the demo page not github page.
Thanks

[onedrawingperday]

@mehedi-sharif
The Homepage link can be modified if your developer edits line 5 of the Timer Theme's theme.toml:
https://github.com/themefisher/timer-hugo/blob/master/theme.toml#L5

Regarding the Hugo Infinity Theme I will test it later today and let you know.

[onedrawingperday]

@mehedi-sharif
The demo of the Hugo Infinity Theme works fine when I execute the Build Script.

However the header background image is identical to the one used in the Hugo Agency Theme

Can you please use a different image for the header of the Inifinity Theme?

Thank you very much.

[digitalcraftsman]

Here is a miss link in this page under homepage button themes.gohugo.io/timer-hugo. it goes to the demo page not github page.

Sorry for missing that one. I've tested it, everything looks good and I'm ready to add it. However...

However the header background image is identical to the one used in the Hugo Agency Theme. Can you please use a different image for the header of the Inifinity Theme?

@onedrawingperday ...why do you propose to change the background of the theme?

Here is a miss link in this page under homepage button themes.gohugo.io/timer-hugo. it goes to the demo page not github page.

As @onedrawingperday already mentioned, just edit the theme.toml according to your needs.

[onedrawingperday]

...why do you propose to change the background of the theme?

@digitalcraftsman It is the same as the one in the Hugo Agency Theme.

I don’t think that themes should use the same open source images in their demos because they will look the same.

Also both of these themes are kind of similar single page applications.

If you think that is not a problem then it’s fine by me

[digitalcraftsman]

Hey Mehedi,

your Infinity theme has been added in https://github.com/gohugoio/hugoThemes/commit/59bb850d32d8dd058a1c52b86191a73dac569b9e. It should be online soon.

[mehedi-sharif]

@digitalcraftsman this is awesome ..

[mehedi-sharif]

@digitalcraftsman one question . I have changed all the homepage url . But it does not appears in hugo theme directory. Can you please check this issue .
Ex: https://themes.gohugo.io/navigator-hugo/
Thanks

[digitalcraftsman]

I have changed all the homepage url . But it does not appears in hugo theme directory. Can you please check this issue .

I guess you've updated the url in the theme.toml file. Your theme has to be updated in this repository in order to pull the latest changes from your repo. This is what I've did yesterday. Please let me know if the changes are still not visible.

[mehedi-sharif]

It works fine . Thanks

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. Feel free to ask questions. We're glad to help.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

[mehedi-sharif]

Hello @digitalcraftsman ,
My core business is selling bootstrap themes . But after getting huge response from users we build few hugo themes and those are really very popular in the community .To clear the misunderstanding about my core business and hugo contribution I build another website dedicated to hugo community called https://gethugothemes.com . In here I will only focus on hugo themes. We have developed a new theme from that brand called "Dot" . Dot is basically a documentation theme . You can get more info here : https://github.com/gethugothemes/dot-hugo-documentation-theme . We worked so hard to make an awesome documentation theme for hugo. Hope you will add this in hugo themes repository and give opportunities to users to get access a great theme.
Thanks from gethugothemes Team

[digitalcraftsman]

Hello @mehedi-sharif,

My core business is selling bootstrap themes . But after getting huge response from users we build few hugo themes and those are really very popular in the community

Great to hear that your themes are used so widely!

We have developed a new theme from that brand called "Dot" . Dot is basically a documentation theme .

As expected you created another great theme :+1:

Hope you will add this in hugo themes repository and give opportunities to users to get access a great theme.

Everything looked fine with your theme. It has been added in https://github.com/gohugoio/hugoThemes/commit/2651ac59e60aaaaf532541c1d7eff96692b8023b and should appear soon on the Hugo theme site.

[mehedi-sharif]

Thank you so much . We have another theme in our list. Soon we will release it .

[mehedi-sharif]

something wrong with this demo
https://themes.gohugo.io//theme/airspace-hugo/fr.
Can you please check this out.
Thanks

[onedrawingperday]

Hello @mehedi-sharif

The slider images are 404. e.g. /img/slider-bg.jpg does not exist in the repo as far as I can tell.

However you really need to remove the promo for the Premium Bitzrox Hugo Theme from the Airspace Theme's README as soon as possible

The README is not the place for promoting other premium themes.

Please do this and let me know.

Thanks.

cc: @digitalcraftsman

[onedrawingperday]

@mehedi-sharif

Also remove the promo for the Bitzrox Premium Theme from the READMEs of
https://themes.gohugo.io/meghna-hugo/
https://themes.gohugo.io/timer-hugo/
https://themes.gohugo.io/infinity-hugo/
https://themes.gohugo.io/vex-hugo/

Please do not ever again post promos to other unrelated premium themes in the READMEs of the free themes that were accepted in this repository.

Thanks.

cc: @digitalcraftsman

[mehedi-sharif]

@onedrawingperday ,
With due respect, Premium one is for those who wants to use a premium product. I offer 6/7 free items for the hugo community and that banner is been on that page almost 6/7 months. No one ever complains about this. The best part here is people are very happy having biztrox in hugo. If the community heads thinks thats its against their policy then I will remove them. But without not getting any output from a community its hard to run contribution for a startup like us.
@digitalcraftsman waiting for your feedback.
Thanks.

[onedrawingperday]

@mehedi-sharif

As far as I am concerned this is not up for discussion.

Also I am quite annoyed because when these themes were reviewed the banner was not there and you added this without asking us.

But anyway I have already notified @digitalcraftsman so when he has the time he will offer his opinion on the matter of running a promo for an irrelevant premium theme in the READMEs of your free themes that are listed here.

EDIT

The community head around here is @bep and I didn’t want to bring him into this, but since you edited your comment and talking about policy I am notifying him now because he is the one who will give you an answer to the points you raised.

[mehedi-sharif]

I never saw any policy that I can not add any premium banner in theme submission. As I mentioned you before we have been added this banner almost 5/6 months ago. Again if it's against the policy I will obviously remove the banner.
Thanks for your concern.

[onedrawingperday]

The banners were added on the 16th of November 2018, right after your last free theme was added.

I saw the commits earlier. I frankly do not have the time to post the links here.

The repository README mentions that Theme Demos should not have promos:

Please make the Example Site's content as neutral as possible.

How could you possibly think that it would be acceptable in the README?

Anyway I have to go now. Hopefully the others can chime in and tell you what they think.

[mehedi-sharif]

@onedrawingperday .
I am not arguing with you for this. If its an issue and if the creators think that the banner should not be in there I will remove that immediately. No rush .
Thanks

[bep]

@mehedi-sharif I'm sorry if our guidelines have not been clear on this. Here is a suggested new policy text:

We currently do not accept ads on the Hugo Theme Site. And since we pull in the READMEs from the themes' GitHub repositories, this rule also extends to these. We will be lenient about this; it is natural to put a link to your company's home page and similar there, but no promotional banners or texts that says "click here to buy the full version" and similar.

You are, of course, free to put (almost) anything you want in your GitHub repo, it just means that it cannot be promoted on this site.

Also, I would suggest that you change the text on the banner. It looks like you ask for contributions to "the Hugo community" (i.e. all of us).

/cc @digitalcraftsman @onedrawingperday

[mehedi-sharif]

@bep ,
Thanks for your clarification. I will remove all the content that conflicts with the new policy. My question here is if authors like us can not promote their products through their page how could they gain some profit from this platform ? Even you can promote you premium products through your free plugins in wordpress or another open source platform. I honor your decision but there should a scope for us. Hope you consider my suggestion.
Thanks

[onedrawingperday]

We currently do not accept ads on the Hugo Theme Site. And since we pull in the READMEs from the themes' GitHub repositories, this rule also extends to these. We will be lenient about this; it is natural to put a link to your company's home page and similar there, but no promotional banners or texts that says "click here to buy the full version" and similar.

@bep I am fine with the above. If @digitalcraftsman also agrees then this should be added to make the README even clearer.

@mehedi-sharif Yours are not the only themes listed in this repository that also have premium versions. For example please have a look at the README of the Hugo Sodium Theme

That theme's author has turned the name of the theme in line 3 into a link that points to his website.

Also further down in the README there is a simple link about the Pro Version and a brief mention of the features that are not available in the Free version.

I have taken issue with the way you made a campaign for an irrelevant theme and because you have placed its screenshot in the README of every single one of your free themes listed here.

The theme README is supposed to be strictly about the theme in question. It is not meant to be used as a springboard to promote a completely different theme.

If your free themes have PRO versions I suggest that you follow the above example of the Hugo Sodium Theme as a guide:

• Simple links, brief descriptions.
• No banners
• Regarding that banner Help us to run our contribution to the Hugo community (that I hadn't noticed thanks @bep ) I suggest that you remove it.
• Just post a simple Donation link or a brief text in the form of: Help us continue developing free versions of our themes for Hugo. or something similar.
• We would appreciate it if you could remove the promotion about the Bitzrox Premium Theme from the READMEs as soon as possible.

Please once you look into the above let us know.

Thanks.

[mehedi-sharif]

@onedrawingperday . Thank you so much for your suggestion . I will update the readme file . But here is another question. Right now all my themes are free and I have only one theme that is premium . If I add a small promotion section for my premium theme ( obviously I will show you here ) will that work ? .
And yes I will update the repositories soon .
Thanks

[onedrawingperday]

@mehedi-sharif

Right. So basically you want to mention that one and only premium theme in all of your free themes' READMEs.

I suppose that if of course @bep and @digitalcraftsman are OK you could create a section at the bottom of each theme's README with something like:

If you like our free (insert-theme-name-here) theme please consider checking out our Bitzrox Premium Theme that has the following: (insert-brief-list-of-cool-features-here).

Or something similar.

If the others object to what I wrote here, then hopefully they can offer a better suggestion than mine.

[mehedi-sharif]

Thank you so much for your time and patience . Soon I will update whole repositories .
Thanks

[onedrawingperday]

Ok. Cool. When you do that let us know.

[digitalcraftsman]

Hello everyone,

the following summary should clarify how a README should look like with respect to all parties' interests:

• text and links must have a neutral wording
• no intrusive banners / ads / promotions
• no prompting "click-here-to-buy"-links
• the focus of the README should remain on the corresponding theme

It's fine to

• ask for donations in order to support the theme authors
• add a link saying something like "Pro version" (similar to how Sodium does it)
• link to external sites where the premium theme is actually sold
• add a small summary of what other features the pro version has (compare with Sodium)
• add a small promotion section at the bottom of a README (as suggested here by @onedrawingperday):

If you like our free (insert-theme-name-here) theme please consider checking out our Bitzrox Premium Theme that has the following: (insert-brief-list-of-cool-features-here).

@mehedi-sharif please update the READMEs of your themes accordingly as soon as possible. Furthermore, please change the text of the banner that encourages users to donate to the Hugo community as it's misleading and doesn't mention the intended donatee (i.e. you).

Having the above said we'll try to update the policy with more precise information in regard to promotions, commercial themes etc.

[digitalcraftsman]

@mehedi-sharif back to the original problem regarding the airspace theme.

@onedrawingperday already mentioned that

The slider images are 404. e.g. /img/slider-bg.jpg does not exist in the repo as far as I can tell.

While checking airspace theme demo I noticed that your theme mixes HTTPS and HTTP requests which can be considered a security issue. Hence (manipulable) HTTP requests are blocked by the browser. This mainly affects Google fonts.

If there's something that looks wrong please let us know.

[mehedi-sharif]

Please check this repo. If you guys think its ok now then I will change every repo according to this example.
Thanks
https://github.com/themefisher/meghna-hugo

[digitalcraftsman]

The changes look fine and can be applied to all themes.

[mehedi-sharif]

Please check this one .
https://github.com/themefisher/airspace-hugo . If you think the page is ok then please add it . We removed all kind of promotions here .
Thanks

[mehedi-sharif]

I saw this repo https://themes.gohugo.io/hugo-sodium-theme/ . They refer to their product page not github page .

[onedrawingperday]

@mehedi-sharif Correct. I deleted my previous comment because it was made in error.

@digitalcraftsman will give you further feedback.

[mehedi-sharif]

@digitalcraftsman ,
Still I am waiting for your response . After getting your yes I will change all readme files from all repositories .

[digitalcraftsman]

Still I am waiting for your response . After getting your yes I will change all readme files from all repositories .

As mentioned above your READMEs of the meghna and airspace look fine and can be used as blueprint for your other themes.

I saw this repo themes.gohugo.io/hugo-sodium-theme . They refer to their product page not github page .

Most of the time a theme solely lives on GitHub. But if you host your own website you're free to link to it as the author of the sodium theme did.

[mehedi-sharif]

Thank you so much for your reply @digitalcraftsman . I am going to update them all

[mehedi-sharif]

I am not sure why some of the pages showing errors when its ok with the downloaded files
https://themes.gohugo.io/theme/navigator-hugo/en/service .
And also demo button is missing in this themes
https://themes.gohugo.io/timer-hugo/
https://themes.gohugo.io/infinity-hugo/
Thanks

[onedrawingperday]

I know about your themes’ demos not generating currently.

Please have a look at #547 and the discussion at #556

Note that work hasn’t commenced yet to address these issues.

I will notify you in your themes’ repositories once I’ve looked into the errors.

[mehedi-sharif]

Hello @onedrawingperday ,
I created a new theme
https://github.com/themefisher/restaurant-hugo-theme .
Want to add the hugo repo .
Thanks

[digitalcraftsman]

Hello Mehedi,

while checking the repository of the restaurant theme I noticed that the metadata in theme.toml and the screenshots in images are missing.

Furthermore, the LICENSE file contains (by default) the MIT license while the README states, that the theme is released under the Creative Commons license. I guess you want to use the latter one. Hence please update the license text accordingly.

Could you add a rule to .gitingore that prevents the tracking of .DS_STORE` files and remove the existing ones?

Please let us know when you fixed the issues

[onedrawingperday]

@mehedi-sharif

Regarding the broken demo of Timer Hugo since the content directory is inherited from the HugoBasicExample not all content files have tags and the ERROR is caused by delimit that looks for .Params.tags in every content file.

To fix the theme's demo you need to change line 12 of timer-hugo/layouts/_default/single.html to the following:

{{ if ne .Params.tags nil }}{{ delimit .Params.tags ", " }}{{ end }}

Basically the delimit function needs to be wrapped within a condition that checks if .Params.tags exist.

Also regarding the Infinity Hugo theme it's demo has been fixed and it is already live on the Hugo website.

[mehedi-sharif]

@digitalcraftsman I will update all the things according to your requirements and submit it soon.
@onedrawingperday I update one of my repository with more resources and also add 3 premium item at the bottom . If you think that I can not do this then I will remove them .
https://github.com/themefisher/airspace-hugo
Waiting for your response .
Thanks

[onedrawingperday]

@mehedi-sharif

The Premium themes section at the end of the Airspace Thene’s README looks ok.

Also please have a look at fixing the Timer Hugo Theme demo by applying the fix that I posted above and let me know.

[digitalcraftsman]

@mehedi-sharif are there any updates regarding our comments above?

[mehedi-sharif]

We made an update according to that issue .

[onedrawingperday]

@mehedi-sharif The Timer Hugo demo still fails to generate in the latest production deployment of the Hugo themes website:

12:58:24 PM:  ==== PROCESSING  timer-hugo  ======
12:58:24 PM: Building site for theme timer-hugo using default content to ../themeSite/static/theme/timer-hugo/
12:58:24 PM: ERROR 2019/03/16 10:58:24 render of "page" failed: "/opt/build/repo/timer-hugo/layouts/_default/single.html:12:31": execute of template failed: template: _default/single.html:12:31: executing "_default/single.html" at <delimit .Params.tags...>: error calling delimit: can't iterate over <nil>
12:58:24 PM: Error: Error building site: failed to render pages: render of "page" failed: "/opt/build/repo/timer-hugo/layouts/_default/single.html:12:31": execute of template failed: template: _default/single.html:12:31: executing "_default/single.html" at <delimit .Params.tags...>: error calling delimit: can't iterate over <nil>
12:58:24 PM: FAILED to create exampleSite for timer-hugo

I have given you guidance for a fix over here.

Can you please look into it?

[onedrawingperday]

I see that with the latest deploy the Timer Hugo demo is fixed: https://themes.gohugo.io/theme/timer-hugo/

👍

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. Feel free to ask questions. We're glad to help.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

[mehedi-sharif]

Hello Team,
Here is our brand new hugo theme called kross .
https://github.com/themefisher/kross-hugo-portfolio-template . Its a MIT licensed free theme .

[digitalcraftsman]

Hey Mehedi,

thank your for submitting another awesome theme :+1: Are you ready for the review?

Please make sure that the thumbnail and screenshot in the images folder have the right dimensions. You can find them in the README.

Furthermore, your theme requires the extended version of Hugo in order to compile the SCSS files to CSS stylesheets. With distributing themes on the Hugo theme site we want to ensure, the normal version of Hugo can also be used to run this theme. Hence commit the resources folder with the compiled CSS stylesheets as well.

On the homepage you're linking to the about page. In this case it's not necessary to use absURL, because Hugo already makes sure that .URL points to the right place. .URL starts with a leading slash which causes absURL (by design) to make this url relative to the root directory, which is not the url we want to point to.

[mehedi-sharif]

Thanks for your appreciation .
We fix all the issues based on kross theme , and here is another theme personal blog theme
https://github.com/themefisher/parsa-hugo-personal-blog-theme .
Waiting to see the themes in hugo repository .
I have a question , I dont know why our themes are not in the top of hugo themes list . We never saw our theme at the top , we make update everyday .
Thanks

[digitalcraftsman]

I have a question , I don't know why our themes are not in the top of hugo themes list . We never saw our theme at the top , we make update everyday .

Themes are added as Git submodules that are basically a reference to a commit in an external repository. Those references have to be updated manually by pulling the changes from your theme repos and committing them. Pulling the changes happens about once a week. Once a commit (i.e. with updated themes) is pushed a rebuild of the Hugo theme site is triggered. At the end the website does not reflect updates in realtime.

---

So far, the Parsa theme looks good. But is it intended that the search in the demo is disabled?

One minor issue in both of the Parsers' and Kross' README is that the headline and the shields (from shields.io) at the very top above the give are not rendered correctly because HTML and Markdown code is mixed. Hence I suggest to turn everything into plain HTML. I tried various variations, included linebreaks etc. but nothing made the parser parse it the expected way.

[mehedi-sharif]

Themes are added as Git submodules that are basically a reference to a commit in an external repository. Those references have to be updated manually by pulling the changes from your theme repos and committing them. Pulling the changes happens about once a week. Once a commit (i.e. with updated themes) is pushed a rebuild of the Hugo theme site is triggered. At the end the website does not reflect updates in realtime.

I am not clear about your explanation, and it does not need to be . but would love to see our templates at the top sometimes , it helps inspire us a lot.

So far, the Parsa theme looks good. But is it intended that the search in the demo is disabled?

I have to check , not sure is search disable or not.

One minor issue in both of the Parsers' and Kross' README is that the headline and the shields (from shields.io) at the very top above the give are not rendered correctly because HTML and Markdown code is mixed. Hence I suggest to turn everything into plain HTML. I tried various variations, included linebreaks etc. but nothing made the parser parse it the expected way.

We will fix this issue .
Thanks for your time and reply .

[digitalcraftsman]

I am not clear about your explanation, and it does not need to be . but would love to see our templates at the top sometimes , it helps inspire us a lot.

I've just updated all Hugo themes again.

We will fix this issue .

Let me know once you're done.

[mehedi-sharif]

We fixed that issue . Could you please check now .
Thanks

[digitalcraftsman]

I've added the Kross theme and will promote it on Twitter as usual.

Regarding the Parsa theme: make sure that you link the search index correctly. Otherwise, your script is fetching from the wrong url.

The best way to generate a valid url is to use a template function like absURL as follows:
var indexURL = {{ "index.json" | absURL }}

 ...
 $.getJSON(indexURL, function( data ) {

Just make sure that you declare indexURL inside a Hugo template where you can absURL.

[mehedi-sharif]

We fixed this issue . please check persa .

[digitalcraftsman]

Everything looks great now. You theme has been added in https://github.com/gohugoio/hugoThemes/commit/60856f75bf300f6bccd7e46ec33a9ba324fb31e7. It appear soon on the Hugo theme site.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. Feel free to ask questions. We're glad to help.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

[mehedi-sharif]

here is our another theme https://github.com/themefisher/Academia-hugo .
Its a forked theme from academic .

[digitalcraftsman]

Dear Mehedi,

excuse the delays in the review process of your theme. Right now, I'm in the final phase of finishing my bachelor thesis. Hence I'm want to ask for a little patience.

Thank you.

[mehedi-sharif]

@digitalcraftsman ,
Thanks for your reply . We have no issue with the release. If the process takes early users can get this product early. That's my concern. Best wishes for your exam.
Thanks

[onedrawingperday]

@mehedi-sharif
I had a look at the submitted Academia theme which is a fork of Academic and I have noticed the following issues:

1. Please update the contents of the Academia theme's theme.toml because at the moment it is identical to the one used for Academic which is the original of this fork.

   1. From what I can tell this is a re-worked theme that looks different from Academic as shown here. However the theme's screenshots are identical to the ones from the Academic theme. Can you please update the /images/ folder to contain the correct screenshots?

2. When I test your theme with the Themes Site Build Script I get the following breaking errors:

ERROR 2019/07/27 09:26:41 error: failed to transform resource: TOCSS: failed to transform "main_parsed.scss" (text/x-scss): this feature is not available in your current Hugo version, see https://goo.gl/YMrWcn for more information
ERROR 2019/07/27 09:26:41 Homepage not found or duplicate homepages detected for a localization! Add the `home/` folder (especially `/home/index.md`) to each language's content folder. For example, your site should have a `content/home/` folder containing `index.md` and your homepage sections, or for multi-language sites, `content/en/home/` and `content/zh/home/` etc. Refer to the 'Build Your Homepage' and 'Language' documentation at https://sourcethemes.com/academic/docs/ and the example homepage at https://github.com/gcushen/hugo-academic/tree/master/exampleSite/content/home/index.md .
Error: Error building site: logged 2 error(s)

For the first ERROR please generate the theme's resources locally and then commit them in the theme's repository as stated in the theme submission guidelines

For the second ERROR the console message provides a detailed solution that you need to apply.

Please do the above and let me know so that I can review the theme further.

Thanks.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. Feel free to ask questions. We're glad to help.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

[mehedi-sharif]

Hello ,
We fixed all the issues you noted above . Could you please check and add in your list.
Thanks

[onedrawingperday]

Hello @mehedi-sharif

I am still getting the console errors mentioned in my post above after pulling the latest changes.

Building site for theme Academia-hugo using default content to ../themeSite/static/theme/Academia-hugo/
ERROR 2019/09/25 14:37:07 Transformation failed: TOCSS: failed to transform "main_parsed.scss" (text/x-scss): this feature is not available in your current Hugo version, see https://goo.gl/YMrWcn for more information
ERROR 2019/09/25 14:37:07 Homepage not found or duplicate homepages detected for a localization! Add the `home/` folder (especially `/home/index.md`) to each language's content folder. For example, your site should have a `content/home/` folder containing `index.md` and your homepage sections, or for multi-language sites, `content/en/home/` and `content/zh/home/` etc. Refer to the 'Build Your Homepage' and 'Language' documentation at https://sourcethemes.com/academic/docs/ and the example homepage at https://github.com/gcushen/hugo-academic/tree/master/exampleSite/content/home/index.md .
Error: Error building site: logged 2 error(s)

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. Feel free to ask questions. We're glad to help.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

[somratpro]

Hello @onedrawingperday , I checked many times, but found no error on consol, please check this video

[onedrawingperday]

Hello @Somrat37

In the workstation that you are using to test the theme, can you please post the output of the command hugo version from your terminal?

[onedrawingperday]

@Somrat37
Actually I just came back to my workstation and I had a look again at the theme repo: https://github.com/themefisher/Academia-hugo

Over here: https://github.com/themefisher/Academia-hugo/blob/d7cc8df34b58a7fd97c032178d8ffda537a6e805/layouts/partials/site_head.html#L105 you are calling a SASS file and converting to CSS.

Yet you have not committed the theme's resources as mentioned in the repo README

Also my comment above from July the 27th, mentions the same guidance about fixing the issues encountered while testing the Academia-Hugo theme with the Themes Site Build Script.

I am afraid that I cannot keep repeating myself.

Also note that I am closing this issue. When you fix the issues as instructed above then (either you or @mehedi-sharif ) will need to open a new theme submission. There are guidelines in this repo that need to be fulfilled before submitting a theme for review. Also these guidelines are about to be updated once #668 is addressed and also may change in the future again. So from now on it will be best to have one issue per theme submission.

Thank you.

cc: @digitalcraftsman

[mehedi-sharif]

@onedrawingperday Thanks for your feedback. We are working on this . In the mean time we have added a new theme e-commerce (https://github.com/themefisher/Hargo-hugo-ecommerce-theme ) I think this one will be the first hugo e-commerce theme . Hope you will check this out and add hugo theme list.
Thanks

[ogurcan]

I am also getting the same error with @onedrawingperday .

After I upgrade my Hugo to 0.67.0 from 0.63.0, I began to get the following error message when I execute blogdown::build_site() in RStudio: Homepage not found or duplicate homepages detected for a localization!. Before the upgrade, it was compiling without any problem. The source code of my web site is found at https://gitlab.com/ogurcan/web-site

Can anyone help me?