Handbrake: [macOS] de.lproj not showing up anymore

[Nomis101]

Description of the problem

This is a pretty wired thing, but despite the presence of the de.lproj folder in the macOS Nightly builds, the HandBrake GUI is not german anymore on a german macOS. It seems only fragments from Localized.strings are localized. And the most wired thing, only on the official nightlies, on my own build (with the exact same source code, but more recent version of cmake) it is working as it should.
I'm quite sure it was working initially in the Nightly, because I checked it. To be sure it is not a problem on macOS 10.14 beta, I checked on 10.13.6 as well, but it is the same issue there.

Steps to reproduce the problem

Open Nightly on german macOS

HandBrake version (e.g., 1.0.0)

HandBrake-20180822104100-b703c42-master

Operating system and version (e.g., Ubuntu 16.04 LTS, macOS 10.3 High Sierra, Windows 10 Creators Update)

macOS 10.14 and macOS 10.13.6

Error message text or screenshot

[bradleysepos]

Thanks for the report. Please provide your Xcode version and also the output of xcodebuild -version so @sr55 can compare to the build server.

[galad87]

Fixed in abe12fe7a7798e2beb04bc73d1437f5b02be5802

[Nomis101]

Thanks for fixing, I will test the nightly tomorrow then.

$ xcodebuild -version
Xcode 10.0
Build version 10L232m

By the way, I updated and fixed some translations on Transifex (apart from the still missing new strings from bug 1531).

[Nomis101]

How long does it take, until the patch is in the current nightly? Just now I downloaded nightly
HandBrake-20180823150654-abe12fe-master
But in this one the issue is still not fixed. And the deployment target is still 10.7:

$ otool -l /HandBrake.app/Contents/MacOS/HandBrake:
...
    uuid 609F957A-B30A-3EAF-8345-3A563B20DEB7
Load command 9
      cmd LC_VERSION_MIN_MACOSX
  cmdsize 16
  version 10.7
      sdk 10.13
Load command 10
        cmd LC_UNIXTHREAD
    cmdsize 184
...

[bradleysepos]

That one is a few days old according to the date in the file name. There's already a newer build dated 8/26 available, which should include fixes from the last few days.

[Nomis101]

Thanks. I tested
HandBrake-20180826130312-d3a3ac2-master
But unfortunately its still the same situation like in my comment above.

[bradleysepos]

Just to make sure, you did perform a completely fresh build? rm -rf build; ./configure && make -C build?

[Nomis101]

I do not see this problem with my own build. I only see it with the official nightlies. For my own builds I do

rm -rf /Volumes/Developer/HandBrake/build
rm -rf /Volumes/Developer/HandBrake/download
cd /Volumes/Developer/HandBrake
./configure --launch-jobs=$(sysctl -n hw.ncpu) --force --launch --enable-x265 --optimize=speed --xcode-config=osx1010.x86_64

[bradleysepos]

Ah sorry, got my wires crossed. Perhaps @galad87 will have another idea.

[galad87]

@sr55 how are the nightly built? Does it use a specific xcode-config?

[sr55]

nice ./configure --xcode-config=osx107.x86_64 --enable-x265 --launch-jobs=2 --launch

That hasn't been updated in a while it seems.

It's running High Sierra but probably doesn't have quite the latest xcode.

I guess that config needs dropped now or set to 110?

[bradleysepos]

nice ./configure --xcode-config=osx107.x86_64 --enable-x265 --launch-jobs=2 --launch

Ha! Called it. 😆

I guess that config needs dropped now or set to 110?

It should be set properly during build, so just drop --xcode-config.

[Nomis101]

I can confirm, that this is now fixed in
HandBrake-20180904193432-d3e071f-master
Thanks!