Gitmoji: :pencil2: Typo in raw emojis list

Created on 26 May 2019  路  4Comments  路  Source: carloscuesta/gitmoji

Hello @carloscuesta :sunglasses:!

I found a typo at https://raw.githubusercontent.com/carloscuesta/gitmoji/master/src/data/gitmojis.json :

Both :pencil: and :pencil2: have the same name property.

I actually use it to auto-generate my semantic-release Github release template, so I get this kind of issue, where the same commit appears both on Fixing typos and Writing docs :

Screen Shot 2562-05-27 at 00 14 10

If it's not considered a typo for you, I can also do something like code.replace(':', ") and it will be fine, just let me know.

p.s : how I use it can be found at :

bug

Most helpful comment

@Roms1383 yep, its a bug. Thank you for bringing it to attention. Lets change it to pencil2. Agree @carloscuesta ?

All 4 comments

Ok I don't know if it's considered as a typo or not (that's why I let you decide whether to close this issue or not), but anyway I got my template to work properly by switching template's to using code property instead of name :

`{{#if ${code}}}`
...

Sorry for the disturbance 馃

@Roms1383 yep, its a bug. Thank you for bringing it to attention. Lets change it to pencil2. Agree @carloscuesta ?

I agree with you @grissius :+1: Is it considered has a breaking change?

Since it is only about the gitmoji's name it can't be considered has a breaking change. Correct me if I'm wrong 馃槈

Was this page helpful?
0 / 5 - 0 ratings

Related issues

nicgirault picture nicgirault  路  5Comments

jamesarosen picture jamesarosen  路  5Comments

jpventura picture jpventura  路  3Comments

bgreenwell picture bgreenwell  路  5Comments

johannchopin picture johannchopin  路  4Comments