Gitmoji: Improve "refactoring code" moji

Created on 4 Sep 2017  ·  3Comments  ·  Source: carloscuesta/gitmoji

Hello @carloscuesta :sunglasses:!

  • Emoji: ♻️
  • Code: :recycle:
  • Description: 🔨 and 🔧 are visually too similar

🔨 (i.e. refactoring code) and 🔧 (i.e. changing configuration files) are visually too similar, but have totally different meanings in this gitmoji style.

:recycle: was chosen instead of :black-universal-recycling-symbol: due the smaller string length, avoiding to consume a significant amount [commit message header(http://udacity.github.io/git-styleguide/).

emoji

Most helpful comment

We had a similar proposal, see https://github.com/carloscuesta/gitmoji/issues/111#issuecomment-292310869

I prefer ♻️ over 🔨 but 🤔

All 3 comments

We had a similar proposal, see https://github.com/carloscuesta/gitmoji/issues/111#issuecomment-292310869

I prefer ♻️ over 🔨 but 🤔

@carloscuesta I've just read #111 and, IMHO, repositories already using previous emojis should not be an impediment to Gitmoji project evolution/improvement.

The emoji should auxiliate the commit title semantic, not _be_ the title (not even a _kanji_ may contain the whole message idea 😄 ).

That being said, the emoji should satisfy the following conditions:

  • Add enough info to the reviewer decide if the commit should be skipped/reviewed
  • Add relevant info to the changelog script
  • Do not be similar to other emojis used in the same style

Does it make sense?

P.S. I've already adopted your style at sails-firebase 👍

Makes sense to me! Feel free to send a PR @jpventura

Was this page helpful?
0 / 5 - 0 ratings