Gitmoji: Add ☂ for changes relating to improving resilience against misconfiguration/API hiccups/user error/etc

[foosel]

Hello @carloscuesta :sunglasses:!

• Emoji: ☂️
• Code: :open_umbrella:
• Description: Improve error resilience

I'm proposing ☂ as a gitmoji to signify changes relating to improving error resilience of the code, so hardening against misconfiguration, API hiccups, things like that. I run an open source project targeting end users, so quite a number of my commits are about "keeping the end user from shooting themselves into the foot" so to speak. I've been using the above emoji for these for a while now.

[vhoyer]

Can't we abstract your proposal to fall under the umbrella of :lock: (pun intended)?

[foosel]

IMHO an entirely different class of issues and severity.

[KaKi87]

Hey, I'm not sure I understand what kind of code modifications your proposal is related to, could you please give an example ?

[foosel]

Take a look at these:

• Resilience against misuse of API by a third party app: https://github.com/OctoPrint/OctoPrint/commit/0faa6879b48826ebf7646926ae985cb98a9370a5
• Resilience against out-of-storage scenarios prior to updates (user deployed software): https://github.com/OctoPrint/OctoPrint/commit/462f2e602b641f29349172f7f5c0ddc28cba3c9c
• Resilience against Github API hiccups (somewhat common) in CI/CD pipeline: https://github.com/OctoPrint/plugins.octoprint.org/commit/3e4356ecb8f289f2583e531515ffc029b9055555

[KaKi87]

I understand.
@vhoyer @carloscuesta @johannchopin What do you think about it ?
I'm pretty much in favor of adding it, but I don't know if it can't be covered by an already existing gitmoji.

[foosel]

Just for the record, if that proposal gets accepted I'd also be happy to file the corresponding PR.

[johannchopin]

Looks interesting but maybe it is a little bit to specific. If it's about improving dev experience (resilience against misconfiguration) I will recommend to create a DX gitmoji. If its about user error I will just use ♿️

[KaKi87]

Hey !!! There's already #292 :goal_net: :goal_net: Catching errors for this ! I'm surprised no one knew ^^

[KaKi87]

Also I'd like to +1 renaming Catching errors to Adding or updating error handling, but why is the issue locked ?

[carloscuesta]

The issue is locked because the PR has already been merged https://github.com/carloscuesta/gitmoji/pull/378

[KaKi87]

Why that one specifically is locked ? The standard practise is not to lock but only close issues after resolving these.

[carloscuesta]

Because solved issue should not be discussed anymore. I do not lock everyone of them but if I see people is making off-topic comments on a resolved issue that is already closed I lock it.

BTW: Please try to stick with the topic of the issue, please do not move on new topics 🙏

[KaKi87]

Well, you only answered to "why is the issue locked ?" but not to 🥅 resolving this issue or not and renaming its label or not.

[foosel]

🥅 works for me. Wasn't aware of that yet for some reason. Closing this, thanks everyone for the lively discussion! 👍