Files: Crash on Startup

[Crocodile73]

Side loaded new 0.7 running Windows 1909 x64. Loads Files Beta screen, then shuts down. Clean install still the same.

[yaichenbaum]

Do you have any additional drives attached to your device?

[Crocodile73]

Do you have any additional drives attached to your device?

i do yes

[yaichenbaum]

@Crocodile73 To test if that is where the bug is can you try removing them and starting Files UWP again?

[Crocodile73]

@Crocodile73 To test if that is where the bug is can you try removing them and starting Files UWP again?

yes that is the issue. Its starts fine without them.

[yaichenbaum]

Thank you for testing, I am marking this as a critical bug. This is something we will look in to as soon as possible.

[duke7553]

@Crocodile73 Thank you for reporting this. Are these additional storage devices external or internal drives?

[yaichenbaum]

@duke7553 I have seen this issue when connecting my phone to my laptop.

[Crocodile73]

@Crocodile73 Thank you for reporting this. Are these additional storage devices external or internal drives?

they are external USB

[Jviix]

i have this issue without any external drives

[WinObs]

I am curious if this would apply to mapped network drives? I just sideloaded the latest release on 1909 x64 and am crashing after the splash screen.

[generalguy41]

@WinObs That's what I thought initially as my main PC at home is mapped to a network drive, but I just tested it on my Surface which has the same drive mapped and it loaded there.

[WinObs]

Thanks @generalguy41 - I am trying on my main desktop with mapped drives - will give it a shot on my Surface Laptop (3) and see if it works. Thanks.

[duke7553]

Unfortunately, I cannot repro this with my hardware. Since we know it exists, can someone checkout the develop branch and provide us debug info?

[Crocodile73]

Unfortunately, I cannot repro this with my hardware. Since we know it exists, can someone checkout the develop branch and provide us debug info?

sorry been away, what debug do you need, only side loaded the app.

[lampenlampen]

does the crash still happen, if you grant the permission "BroadFileSystemAccess":

Win+R, ms-settings:privacy-broadfilesystemaccess.

[Crocodile73]

does the crash still happen, if you grant the permission "BroadFileSystemAccess":

Win+R, ms-settings:privacy-broadfilesystemaccess.

yes it still crashes, i had it on anyway.

[WinObs]

On my system the overall setting was on but the app itself was not so I toggled it on.

Tried before rebooting and it still crashed. Rebooted and tried again – still crashing.

Rich

From: Crocodile73 [e-mail]
Sent: Tuesday, February 25, 2020 6:54 AM
To: duke7553/files-uwp [e-mail]
Cc: Richard Hay [e-mail]; Mention [e-mail]
Subject: Re: [duke7553/files-uwp] Crash on Startup (#410)

does the crash still happen, if you grant the permission "BroadFileSystemAccess":

Win+R, ms-settings:privacy-broadfilesystemaccess.

yes it still crashes, i had it on anyway.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fduke7553%2Ffiles-uwp%2Fissues%2F410%3Femail_source%3Dnotifications%26email_token%3DAJXJD3GIO6LYPKNW3EDHJMDREUBG5A5CNFSM4KUR62H2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM3VVWY%23issuecomment-590830299&data=02%7C01%7C%7Ccc764ee7ed894f678d7808d7b9e97490%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637182284634333693&sdata=%2BSTgHhm3AvNVEdbqyyUMv6RNwUntOrsO86WMbOLta2k%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJXJD3BFOUGG2P36446PK33REUBG5ANCNFSM4KUR62HQ&data=02%7C01%7C%7Ccc764ee7ed894f678d7808d7b9e97490%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637182284634343698&sdata=tUhcD4sTa4BvcTR%2BP1bvTDcbYMc7mBHR3TcQuMP0zt0%3D&reserved=0.

[Crocodile73]

ok trial and error has lead me to a drive, which is a Samsung SSD Usb 3.0 250gb. This is the issue on my system. But i have checked the drive with all kinds of checks, and its fine, works great and has been plugged in for over 2 years. The odd thing is i have two plugged in, and the other one works connected. Hope this helps

[duke7553]

@Crocodile73 We just need you to clone the master branch and run in a debugger to find out what code causes this issue. (and the output)

Thanks a lot!

[Crocodile73]

@duke7553

Log Name: Application
Source: Application Error
Date: 26/02/2020 17:53:16
Event ID: 1000
Task Category: (100)
Level: Error
Keywords: Classic
User: N/A
Computer: DESKTOP-F3QESHP
Description:
Faulting application name: Files.exe, version: 1.0.0.0, time stamp: 0x5d36223e
Faulting module name: twinapi.appcore.dll, version: 10.0.18362.592, time stamp: 0x125d2980
Exception code: 0xc000027b
Fault offset: 0x00000000000d5cb8
Faulting process ID: 0xd54
Faulting application start time: 0x01d5eccd9be257ae
Faulting application path: C:Program Files\WindowsApps\49306atecsolution.FilesUWP_0.7.0.0_x64__et10x9a9vyk8tFiles.exe
Faulting module path: C:\Windows\System32\twinapi.appcore.dll
Report ID: 3ba66927-5803-4568-8b7c-195b8000170a
Faulting package full name: 49306atecsolution.FilesUWP_0.7.0.0_x64__et10x9a9vyk8t
Faulting package-relative application ID: App

[yaichenbaum]

Is anyone able to run Files from the source code to get more detailed information on what's causing the crash?

[lampenlampen]

Can you create a branch for this issue? Then i will backport the logger to v0.7 and you can create a package, so we can get the stacktrace.

[duke7553]

Does this bug affect any users on 20H1 or higher?

[yaichenbaum]

@lampenlampen Just target the develop branch.

[lampenlampen]

This branch already contains the logger. Can you create a package and link it here?
The affected users can then install it and upload the debug.txt, so we get a crash report.

[Crocodile73]

Does this bug affect any users on 20H1 or higher?

no 19H2 for me.

[Crocodile73]

This branch already contains the logger. Can you create a package and link it here?
The affected users can then install it and upload the debug.txt, so we get a crash report.

does this have to be used with a debug tool?

Activation for 49306atecsolution.FilesUWP_et10x9a9vyk8t!App failed. Error code: Unknown HResult Error code: 0x80040904. Activation phase: COM App activation.

[lampenlampen]

No,
go to the folder %localappdata%, Packages, search there for the folder Files and there in the folder LocalState should be a file debug.txt, which contains a stacktrace.

[Jviix]

Debug from yaichenbaum file:
2020-03-04 15:46:43.7966|INFO|Files.App|App launched
2020-03-04 15:46:43.8258|ERROR|Files.App|Acceso denegado. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED))

Acceso denegado = denied access

Files UWP has permission in file system, so... that's it

[yaichenbaum]

@Jviix If you give file permission access does it resolve the issue?

[Crocodile73]

same info as @Jviix

2020-03-04 13:13:22.3586|ERROR|Files.App|Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED))

[Jviix]

Nope. Same issue. Tried 3 times.

[yaichenbaum]

This is interesting, is anyone able to run from the source code? That should give us more information.

[Jviix]

How can I run from source code? I'll do it

[yaichenbaum]

https://github.com/duke7553/files-uwp/tree/develop#building-files-uwp-from-the-source-code

[Jviix]

Thank you, downloading. I'll update asap.

[yaichenbaum]

@Jviix Thank you so much, doing this will go a long way towards resolving this issue.

[Jviix]

Error No certificate was found with the found fingerprint: 10EF406F2BC44E3C8E8F85988D53990173626FC1 Files.Package

This is the error I get when I try to implement the solution. Help, please

[yaichenbaum]

@Jviix Try again using the develop branch.

[lampenlampen]

@Jviix simple delete the certificates. They are still linked in VS, but the certificate file is not stored on git.

[yaichenbaum]

@lampenlampen If they run from the develop branch they shouldn't have the issue.

[lampenlampen]

@yaichenbaum
They are still referenced:
https://github.com/duke7553/files-uwp/blob/016c05dd54157b1de03ec1f02a74bc658ede7d06/Files.Package/Files.Package.wapproj#L155-L158

[yaichenbaum]

@lampenlampen I am pretty sure that is fine, the main thing is that I removed the fingerprint from the Package.wapproj file.

[lampenlampen]

@yaichenbaum You are right 👍

[Jviix]

Well. After some time, I get this:

2020-03-04 18:42:07.8014|INFO|Files.Filesystem.DrivesManager|Drive added: C:\, Fixed
2020-03-04 18:42:07.8504|INFO|Files.Filesystem.DrivesManager|Drive added: D:\, Fixed
2020-03-04 18:42:08.0209|INFO|Files.App|App launched
2020-03-04 18:42:08.0339|ERROR|Files.App|Acceso denegado. (Exception from HRESULT: 0x80070005)

[lampenlampen]

Do you have some other drives than the C and the D one.

[Jviix]

Nope. Just C and D.

[yaichenbaum]

@Jviix Were you able to build from the source code?

[Jviix]

Yup. That log is from source code.

[Crocodile73]

"type": "startService"
}Š “ycrashes{
"exception": {
"type": "System.UnauthorizedAccessException",
"message": "Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED))",
"stackTrace": " at Windows.Devices.Portable.StorageDevice.FromId(String deviceId)\r\n at Files.Filesystem.DrivesManager.DeviceAdded(DeviceWatcher sender, DeviceInformation args)\r\n at Windows.ApplicationModel.Core.UnhandledError.Propagate()\r\n at Microsoft.AppCenter.Utils.ApplicationLifecycleHelper.<.ctor>b__17_1(Object sender, UnhandledErrorDetectedEventArgs eventArgs)"

[lampenlampen]

@Crocodile73 Can you insert a breakpoint in line 78 in the Drives.cs-file and rerun the app?
I woulb be interested in the Name property of the root-variable.
And in which line is the exception thrown?

To prevent this error, we could simply catch this exception and skip this drive, but i think it would be good to know, why exactly it fails.

[lampenlampen]

1. Is there anything special about the drive?
2. BitLocker?
3. Are you an admin?
4. Can you repro this behavior on another pc with this drive?

[Crocodile73]

i haven't created from source file, i have just trialled and error-ed myself from the info in the directory. The drive is a SSD, I am going to run in another pc, and see what happens. The drive is error free, and has ran in previous builds.

[lampenlampen]

@Jviix Are you sure that you don't have some other removable drive plugged in?
Assuming you and @Crocodile73 have the same error:
The crash happens in the DeviceAdded-method. This method is called by windows, if a removable storage device is added to the computer.

[lampenlampen]

@Crocodile73 It's an external drive?

[Crocodile73]

@lampenlampen yes it is

[lampenlampen]

@Crocodile73 Which letter does the drive has?

[lampenlampen]

@Crocodile73 Did it work in v0.6.6?

[Crocodile73]

@lampenlampen it did yes

[lampenlampen]

Can you open a shell in the root directory of your drive and start Files with files.exe?

UWP apps have automatically file-system permissions of the directory (and downwards) they are launched from in the shell.

[Crocodile73]

@lampenlampen drive does the same on another PC. If i run files from a root directly it crashes still.

[duke7553]

FYI: There may be a fix for this in the develop branch. Please try it out and let us know.

[duke7553]

@lampenlampen @Crocodile73 I'll have a debug package prepared soon with some other fixes. If you want to try it out earlier, the potential fix is now in develop branch.

[Crocodile73]

@lampenlampen @Crocodile73 I'll have a debug package prepared soon with some other fixes. If you want to try it out earlier, the potential fix is now in develop branch.

build from source via the develop branch and it still crashes, unplugged the drive and checked build its 0.7.1.0

[duke7553]

@Crocodile73 Can you run the app from Visual Studio (debug) and let us know what line it breaks on? This would really help me figure out what the issue is.

[Crocodile73]

@duke7553 I don't know if i have done it right but says stack trace line 14

[duke7553]

Which file?

[duke7553]

@Crocodile73 Visual Studio should highlight a line inside a specific file

[duke7553]

Could you give me the stack trace then?

[Crocodile73]

can you give me a brief how too.

[duke7553]

Step One: Launch the app from Visual Studio in debug mode
Step Two: Wait for an exception to be displayed. It should highlight a line number.

[duke7553]

You'll see something like this. Just tell me what .cs file is open or send a screenshot.

[Crocodile73]

loaded .sin file in. top says debug x64 files.launcher?

[KaKi87]

I'm experiencing the same issue.

Here are screenshots of AOMEI Partition Assistant showing the external drive's properties :

Thanks

[KaKi87]

I'm also experiencing a crash when this appears :

Clicking on the Grant Permission button doesn't do anything.

PS : how do you explain that Files needs permission to see my files while my files are shown in the background of that modal ?

[duke7553]

@KaKi87 Please verify you're running the latest code from develop, because that is what this issue is tracking. I'm pretty sure we fixed the second bug you're encountering in the develop branch.

[duke7553]

@Crocodile73 Good! You now need to debug Files.Package.

[KaKi87]

Understood, but I only test Windows Store / AppX releases.

[duke7553]

@KaKi87 We're preparing a new APPX which should be ready soon.

[Crocodile73]

what i got was:-

files.exe!files.view_Models.SettingsViewModel.LoadTerminalApps() Line 363

[duke7553]

@Crocodile73 I added a change that should silently prevent loading the drives that are causing this problem. The app (develop branch) should now launch and log the drive ids which cannot be loaded.

[Crocodile73]

@duke7553 That is working now.

[duke7553]

@Crocodile73 Glad to hear you can use the app now.

[yaichenbaum]

v0.7.1 is in the process of rolling out.