Devilutionx: Item "Drift" in Inventory

[mgpat-gm]

Describe
When you pick up an item in the inventory, it "drifts" to the left(left,up in win10). If you pick it up multiple times without moving the cursor, eventually the item will not fall back in the slot you grabbed it from.

To Reproduce
Steps to reproduce the behavior:

1. Hover cursor over any item in the inventory
2. Left click with mouse.
3. Do not move cursor.
4. Left click again.
5. Repeat 1-4 without moving the cursor to dramatic effect.

Expected behavior
When an item is picked up in vanilla, it jumps so that the item is centered on your cursors location when you clicked on it. It appears as though the cursor is the object that is moving, not the item, in devilutionx. This can have a direct effect on gameplay. If you are trying to get inventory items into your belt or swap items during a battle you could be hindered. It is fairly minor, but noticeable.

Additional context
Version:

• 1.0.1

OS:

• Kubuntu 20.04
• Ubuntu 18.04
• Windows 10

[qndel]

For me it jumps just like in vanilla, I spammed the cursor for good 30 seconds, failed to reproduce
Can you record it or something?

[mgpat-gm]

Video

https://www.youtube.com/watch?v=XFEwH2UiOIw

This was on kubuntu 20.04. It is virtually the same on each OS I use. When I seemingly pause, it is because the item has moved to a spot that cannot be dropped to.

[qndel]

could you compile latest ver and try it there?

[mgpat-gm]

Build version: 1.0.1-8ca15061 on Ubuntu 18.04 has same issue.

[qndel]

is this latest? : P
can you reproduce it on latest on windows 10?

[mgpat-gm]

Maybe I'm not sure what you mean by "latest version". I cloned the repo, compiled it, and tested it. Do you mean compile the lastest release?

[AJenbo]

@mgpat-gm could you try this in a window where no scaling has been applied, afaik this is caused by rounding errors. If possible try providing a video of the issue.

[mgpat-gm]

@AJenbo It appears you are correct. I cannot reproduce this in windowed mode.

[AJenbo]

I wonder if this is an issue if you enable interger scaling?

[mgpat-gm]

Someone with an Nvidia Turing card, AMD Ryzen 2000 or later with integrated graphics, ATI Radeon GCN(circa 2011+) architecture, or Intel Gen 11 graphics will have to test it out. Sadly, none of my four PCs have any of those.

[mgpat-gm]

OIC what you mean. It could be remedied by commit #785 ?

[AJenbo]

Yes, if enabled in ini

[mgpat-gm]

It worked fine with the integer scaling turned on.