I have to complain about Griswold.
He has dared to sell normal items under premium items since commit 9a5ff805ed0c70d95e973012c93ae3dbea8245cb.
Chance4us
All 15 comments
what XD
qndel
on 23 Apr 2020
how can this affect griswold?
qndel
on 23 Apr 2020
In fact, it is strange. It should be checked again. But it seems to affect him.
Chance4us
on 23 Apr 2020
there is no way for this to affect anything as this only moves a hardcoded thing to function arguments which were unused befoer and this function gets called only once, if this affects griswold then all I know about C++ is wrong
qndel
on 23 Apr 2020
I tested it again and it appears to be another commit that is causing the behavior.
Chance4us
on 23 Apr 2020
Can you test and confirm the bug?
Chance4us
on 23 Apr 2020
checked 3 times, works fine for me
qndel
on 23 Apr 2020
Thank you. I will continue to check why it happens.
Chance4us
on 23 Apr 2020
It seems to be commit 7108145a04c902a1638e93d937e48c47549257d0.
Chance4us
on 23 Apr 2020
So that it can be seen you have to scroll through the whole list.
Chance4us
on 23 Apr 2020
It it definitely commit 7108145.
Chance4us
on 23 Apr 2020
Issue found. The following commit have to be applied to resolve it.
https://github.com/diasurgical/devilution/commit/fe82c0b1f17077b3d9a4586cc78fe2be8970f83b
Chance4us
on 24 Apr 2020
Duuude .... and you made me go through that big fat merge commit xD
qndel
on 24 Apr 2020
I'm sorry. Was not an intention.
Chance4us
on 24 Apr 2020
It will be merged this weekend.
AJenbo
on 24 Apr 2020
Related issues
julealgon
路
16Comments
snigel
路
23Comments
Tmkrth
路
25Comments
spitfire
路
22Comments
Chance4us
路
27Comments
Most helpful comment
Duuude .... and you made me go through that big fat merge commit xD