Client: Voting: display same amount of decimals for "Yes" and "No" vote counters

[jounih]

Describe the bug

A vote sometimes has a different number of decimals for number of tokens that voted "Yes" and "No". The precision in a single vote should be the same, otherwise it looks confusing

Mainnet or testnet?
Either

Organization
https://mainnet.aragon.org/#/governance.aragonproject.eth/

To Reproduce

Visit

https://mainnet.aragon.org/#/governance.aragonproject.eth/0x277bfcf7c2e162cb1ac3e9ae228a3132a75f83d4

and click "View vote" on some of the votes

Expected behavior

If "Yes" support has 5 decimals, I would expect the "No" support also have the same precision, not 3 decimals - otherwise it's hard to parse visually

Screenshots

[izqui]

Also I would be smarter about decimals, and if the number has more than say 3 characters in the whole part, show only 2 decimals.

[AquiGorka]

@izqui I think more than 2 decimals should be shown, especially since some tokens consider 18 decimals. Maybe the example from above does not show a big difference (70.08% vs 29.92%) but I imagine other scenarios (like Autark's) where more decimals tell the complete story.

[jounih]

I think the solution is described above (@izqui 's answer). I'll remove the design pending tag. I think this can go in the dev backlog

[jounih]

Will think of a design guideline on decimals in general (also in finance etc)

[eliobricenov]

I think this was solved in https://github.com/aragon/aragon-apps/pull/1112

C.C @nivida

[nivida]

Thanks, @eliobricenov for tagging me here.. There is I have seen an open PR (#1113) that will close this issue. PR #1112 got closed without merging.