Clay: Add icon-desktop

[laugardie]

Hi guys!
I am working on LEXI-882 to include _icon-desktop_ in Clay.

Checking the icons in Clay, I have found another icon called desktop.

This icon is called _display-content_ in Lexicon.

Do you know if the desktop icon in Clay is in use? I would like to know that, to decide if we need to deprecate that icon or to change its name to add the new desktop icon.

[laugardie]

I have just found this icon being used in Portal: Control Panel > System Settings. I will leave this ticket open and I will update it with the SVG and all the info today so we can update and add the icons.

[laugardie]

I will update the title of the issue to Add icon-desktop.
We will need to:

1. Change the icon-desktop name in Clay to icon-display-content so it matches the Lexicon library.
   

1. Add new icon: desktop to Clay. Find the .SVG in LEXI-882
   
   Thanks! :)

[pat270]

In Lexicon CSS (1.x), the desktop icon is . In 2.x, it was changed to what it is now. In 3.x, we are trying to revert it back. Is it possible for Lexicon to name the desktop icon something else like icon-display?

[laugardie]

Hey @pat270, you are right and it shouldn't have been changed before in previous versions. But as both icons are going to coexist, in this case, I think that we need to be cautious with the naming. As names are chosen to clearly represent what icons are to simplify use. Using icon-display for the desktop icon and icon-desktop for the one that represents display content can be confusing. As this is not going to cause a breaking change becuase the class that is already in use is going to stay in use but with a different icon, we should reconsider naming the icons properly to avoid future mistakes.
My suggestions are:

[pat270]

@laugardie I was thinking about having 3 icons:
icon-display
icon-display-content
icon-desktop (deprecate)

[laugardie]

That seems ok for us @pat270

[jbalsas]

I'd say we can simply change this to @laugardie suggestion in 3.x and let the other branches as they are.

In DXP, the desktop icon is only used to display display-content:

private static final String _CATEGORY_ICON = "desktop";

private static final String _CATEGORY_KEY = "display-content";

So, maybe the first proposal makes even more sense... but I'm fine with whatever you agree on.

Really hope those metaphors are more stable from now on 😂

[pat270]

I'm trusting @jbalsas on this one.
I'm going with https://github.com/liferay/clay/issues/3200#issuecomment-625854202.

display
display-content
desktop (deprecated)

[jbalsas]

Hahaha... @pat270! I actually saw @laugardie agree with you, so go for it!!

[jbalsas]

Or talk it through, there's likely no rush to get this in one day earlier. Both options are fine by me!